Looks good.
Thanks, Roger
On 1/18/2017 1:47 AM, Vyom Tewari wrote:
Hi Roger,
Thanks for the review i remove the comment saying it should be treated
as read only. Please find below the latest diff.
Thanks,
Vyom
--- a/src/java.naming/share/classes/javax/naming/CompoundName.java Fri
Dec 23
Hi Roger,
Thanks for the review i remove the comment saying it should be treated
as read only. Please find below the latest diff.
Thanks,
Vyom
--- a/src/java.naming/share/classes/javax/naming/CompoundName.java Fri
Dec 23 09:31:24 2016 +0530
+++ b/src/java.naming/share/classes/javax/naming/C
Hi Vyom,
Please also correct or remove the comment saying it should be treated as
read-only by subclasses.
Roger
On 1/16/2017 4:56 AM, Chris Hegarty wrote:
Looks good. Thanks Vyom.
-Chris.
On 16 Jan 2017, at 09:10, Vyom Tewari wrote:
Hi All,
Please review below the small fix for the
Looks good. Thanks Vyom.
-Chris.
> On 16 Jan 2017, at 09:10, Vyom Tewari wrote:
>
> Hi All,
>
> Please review below the small fix for the issue.
>
> BugId : https://bugs.openjdk.java.net/browse/JDK-8167178
>
> The compatibility impact is minimum as no code in JDK is currently depend on
> i
On 16/01/2017 09:10, Vyom Tewari wrote:
Hi All,
Please review below the small fix for the issue.
BugId : https://bugs.openjdk.java.net/browse/JDK-8167178
The compatibility impact is minimum as no code in JDK is currently
depend on it.
I think this is okay, it is technically an API change bu