Re: RFR: 8158651: ConcurrentModification exceptions in httpclient

2016-06-03 Thread Roger Riggs
ok, thanks; +1 (Determining method level thread safety without per method documentation is a bit of a chore). On 6/3/2016 11:08 AM, Michael McMahon wrote: Hi Roger, All access to the list is synchronized. Yes, I should also remove that printf. It's not required. Pavel also suggested chan

Re: RFR: 8158651: ConcurrentModification exceptions in httpclient

2016-06-03 Thread Michael McMahon
Hi Roger, All access to the list is synchronized. Yes, I should also remove that printf. It's not required. Pavel also suggested changing the LinkedList to an ArrayList when I told him the size is nearly always small (1 or 2 elements). So, I will also change that. Thanks Michael. On 03/06/16

Re: RFR: 8158651: ConcurrentModification exceptions in httpclient

2016-06-03 Thread Roger Riggs
Hi Michael, Looks ok as long as the response_cfs list can't be shrunk by a different thread. (cfs_len can be stale). And 577: probably a printf to system.err isn't the ultimate in robustness or debugging. Roger On 6/3/2016 10:40 AM, Michael McMahon wrote: Could I get the following sma