Re: RFR: 8157965 update httpserver logging to use java.lang.System.Logger

2016-10-20 Thread Chris Hegarty
> On 19 Oct 2016, at 16:29, Daniel Fuchs wrote: > > Thanks Roger! > > On 19/10/16 16:01, Roger Riggs wrote: >> Hi Daniel, >> >> looks fine. >> >> (The style differences are disconcerting but are consistent within the >> file). > > Yes. I preserved the original style though it was hurting > m

Re: RFR: 8157965 update httpserver logging to use java.lang.System.Logger

2016-10-19 Thread Mandy Chung
> On Oct 19, 2016, at 7:52 AM, Daniel Fuchs wrote: > > Hi, > > Please find below a patch that updates jdk.httpserver to use > System.Logger. > > As a result jdk.httpserver no longer requires java.logging. > > webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8157965/webrev.00 > issue: https:/

Re: RFR: 8157965 update httpserver logging to use java.lang.System.Logger

2016-10-19 Thread Michael McMahon
Looks good Daniel. Thanks, Michael On 19/10/2016, 15:52, Daniel Fuchs wrote: Hi, Please find below a patch that updates jdk.httpserver to use System.Logger. As a result jdk.httpserver no longer requires java.logging. webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8157965/webrev.00 issue:

Re: RFR: 8157965 update httpserver logging to use java.lang.System.Logger

2016-10-19 Thread Daniel Fuchs
Thanks Roger! On 19/10/16 16:01, Roger Riggs wrote: Hi Daniel, looks fine. (The style differences are disconcerting but are consistent within the file). Yes. I preserved the original style though it was hurting my eyes ;-) Having a mixed style was much worse. best regards, -- daniel Rog

Re: RFR: 8157965 update httpserver logging to use java.lang.System.Logger

2016-10-19 Thread Roger Riggs
Hi Daniel, looks fine. (The style differences are disconcerting but are consistent within the file). Roger On 10/19/2016 10:52 AM, Daniel Fuchs wrote: Hi, Please find below a patch that updates jdk.httpserver to use System.Logger. As a result jdk.httpserver no longer requires java.loggin