Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs

2016-01-29 Thread Alan Bateman
On 28/01/2016 23:47, Claes Redestad wrote: Sure, as this is package-private API a short description and reference to the URI::toURL method whose specification we adhere to should suffice: http://cr.openjdk.java.net/~redestad/8147462/webrev.06/ This looks good - thanks! -Alan

Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs

2016-01-28 Thread Claes Redestad
On 2016-01-28 20:56, Alan Bateman wrote: This looks okay. I think it would be good to put a javadoc comment on this method, also maybe move it to below all the constructors rather than in the middle. -Alan. Sure, as this is package-private API a short description and reference to the UR

Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs

2016-01-28 Thread Alan Bateman
This looks okay. I think it would be good to put a javadoc comment on this method, also maybe move it to below all the constructors rather than in the middle. -Alan. On 28/01/2016 16:38, Claes Redestad wrote: On 2016-01-28 16:52, Chris Hegarty wrote: ... This looks fine Claes. Thanks

Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs

2016-01-28 Thread Chris Hegarty
On 28 Jan 2016, at 16:38, Claes Redestad wrote: > On 2016-01-28 16:52, Chris Hegarty wrote: >>> ... >> This looks fine Claes. > > Thanks, Chris! > >> >> Maybe just a comment on the fact that character based comparison is >> being used for perf reasons. >> >> In an older version of the webrev,

Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs

2016-01-28 Thread Claes Redestad
On 2016-01-28 16:52, Chris Hegarty wrote: ... This looks fine Claes. Thanks, Chris! Maybe just a comment on the fact that character based comparison is being used for perf reasons. In an older version of the webrev, there was an updated to an existing test, test/java/net/URI/URItoURLTest

Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs

2016-01-28 Thread Chris Hegarty
On 27 Jan 2016, at 17:24, Claes Redestad wrote: > > On 2016-01-18 17:20, Claes Redestad wrote: >> >> The ability for URLStreamHandler implementations to override the parseURL >> method seem to prevent this improvement unless we only do this for a subset >> of known, well-behaved URLStreamHan

Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs

2016-01-27 Thread Claes Redestad
On 2016-01-18 17:20, Claes Redestad wrote: The ability for URLStreamHandler implementations to override the parseURL method seem to prevent this improvement unless we only do this for a subset of known, well-behaved URLStreamHandlers, which likely defeat the optimization by adding complexity

Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs

2016-01-18 Thread Alan Bateman
On 18/01/2016 19:26, Chris Hegarty wrote: On 18 Jan 2016, at 16:20, Claes Redestad > wrote: On 2016-01-18 15:34, Chris Hegarty wrote: On 18/01/16 14:09, Alan Bateman wrote: On 17/01/2016 15:30, Claes Redestad wrote: Hi, please review this patch which mi

Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs

2016-01-18 Thread Chris Hegarty
> On 18 Jan 2016, at 16:20, Claes Redestad wrote: > > On 2016-01-18 15:34, Chris Hegarty wrote: >> On 18/01/16 14:09, Alan Bateman wrote: >>> >>> On 17/01/2016 15:30, Claes Redestad wrote: Hi, please review this patch which might make URI.toURL more efficient Webrev:

Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs

2016-01-18 Thread Claes Redestad
On 2016-01-18 15:34, Chris Hegarty wrote: On 18/01/16 14:09, Alan Bateman wrote: On 17/01/2016 15:30, Claes Redestad wrote: Hi, please review this patch which might make URI.toURL more efficient Webrev: http://cr.openjdk.java.net/~redestad/8147462 Bug: https://bugs.openjdk.java.net/browse/

Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs

2016-01-18 Thread Chris Hegarty
On 18/01/16 14:09, Alan Bateman wrote: On 17/01/2016 15:30, Claes Redestad wrote: Hi, please review this patch which might make URI.toURL more efficient Webrev: http://cr.openjdk.java.net/~redestad/8147462 Bug: https://bugs.openjdk.java.net/browse/JDK-8147462 This patch exploits the fact tha

Re: RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs

2016-01-18 Thread Alan Bateman
On 17/01/2016 15:30, Claes Redestad wrote: Hi, please review this patch which might make URI.toURL more efficient Webrev: http://cr.openjdk.java.net/~redestad/8147462 Bug: https://bugs.openjdk.java.net/browse/JDK-8147462 This patch exploits the fact that URI will apply the same validation t