Thanks Alan. All comments accepted, except as clarified below.
Michael
On 09/04/14 15:07, Alan Bateman wrote:
On 08/04/2014 18:49, Michael McMahon wrote:
Could I get the following reviewed please?
In addition to providing generic support for java.net.SocketOption,
it also includes 8032808, wh
Thanks Chris.
Michael.
On 09/04/14 13:34, Chris Hegarty wrote:
This is a nice addition, and looks very good to me.
Just a few small comments:
1) SocketImpl getOption/setOption need javadoc to describe how they can
throw IOException. Maybe even the same, of similar javdoc to the
socket t
On 08/04/2014 18:49, Michael McMahon wrote:
Could I get the following reviewed please?
In addition to providing generic support for java.net.SocketOption,
it also includes 8032808, which implements a platform specific
socket option SO_FLOW_SLA (in jdk.net)
There are changes to two repos:
http:
This is a nice addition, and looks very good to me.
Just a few small comments:
1) SocketImpl getOption/setOption need javadoc to describe how they can
throw IOException. Maybe even the same, of similar javdoc to the
socket type equivalent methods?
2) New protected methods in SocketImpl ne
