On 04/03/2014 11:54, Mark Sheppard wrote:
Hi Alan,
thanks for the response. I originally had a CHECK_NULL_RETURN after
getBraodcast and tests
failed on Macos, but not on other platforms!
The issue is that getBroadcast returns NULL when broadcast is not
available for an interface, or when th
Hi Alan,
thanks for the response. I originally had a CHECK_NULL_RETURN after
getBraodcast and tests
failed on Macos, but not on other platforms!
The issue is that getBroadcast returns NULL when broadcast is not
available for an interface, or when the ioctl calls
return an error. The former i
Chris,
thanks for the response.
I can use the common CHECK_NULL_RETURN convention if preferred.
The reason I went with if ( name_utf != NULL) { ...} else { ...} is
because the != NULL is the most
likely code path in getByName.
Nonetheless, I'll make the change for consistency.
regards
Mark
This looks good to me Mark.
Trivially, and it is more of a stylistic preference, towards the end of the
Solaris NetworkInterface.c I would remove the if (ob) … else, and use
CHECK_NULL_RETURN(obj, NULL). But, what you have is right, either is fine.
-Chris.
On 4 Mar 2014, at 11:06, Mark Sheppar
On 04/03/2014 11:06, Mark Sheppard wrote:
Hi
please oblige and review the following changes
http://cr.openjdk.java.net/~msheppar/8025293/webrev/
to address the issue in
https://bugs.openjdk.java.net/browse/JDK-8025293
this applies additional checks after JNI native calls in
src/solaris/nati
