Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-22 Thread Andrew Hughes
- Original Message - > On 21/04/2015 16:04, Michael McMahon wrote: > > : > > > > http://cr.openjdk.java.net/~michaelm/8078276/webrev.1/ > Before you push this, shouldn't the test have copyright Red Hat? There's > an example in the same directory. > > -Alan > Yes, I was thinking the sam

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-22 Thread Severin Gehwolf
On Tue, 2015-04-21 at 16:09 +0100, Alan Bateman wrote: > On 21/04/2015 16:04, Michael McMahon wrote: > > On 21/04/15 14:56, Alan Bateman wrote: > >> : > >>> > >> Can the test be moved to jdk/test/com/sun/jndi/dns as that seems to > >> be where the other tests are? Also I assume this will need a >

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-21 Thread Alan Bateman
On 21/04/2015 16:04, Michael McMahon wrote: : http://cr.openjdk.java.net/~michaelm/8078276/webrev.1/ Before you push this, shouldn't the test have copyright Red Hat? There's an example in the same directory. -Alan

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-21 Thread Alan Bateman
On 21/04/2015 16:04, Michael McMahon wrote: On 21/04/15 14:56, Alan Bateman wrote: : Can the test be moved to jdk/test/com/sun/jndi/dns as that seems to be where the other tests are? Also I assume this will need a copyright header before it is pushed. -Alan I had pushed it already. So, I

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-21 Thread Michael McMahon
On 21/04/15 14:56, Alan Bateman wrote: On 20/04/2015 18:32, Severin Gehwolf wrote: : OK fixed: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-6991580/webrev.02/ FWIW, I don't think the test needs IP addresses of DNS servers to be functional, though. All it really does is passing it to InetAd

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-21 Thread Alan Bateman
On 20/04/2015 18:32, Severin Gehwolf wrote: : OK fixed: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-6991580/webrev.02/ FWIW, I don't think the test needs IP addresses of DNS servers to be functional, though. All it really does is passing it to InetAddress.getByName(). Prior this patch DnsC

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-21 Thread Michael McMahon
On 20/04/15 18:32, Severin Gehwolf wrote: On Mon, 2015-04-20 at 12:24 -0400, Andrew Hughes wrote: - Original Message - Adding in net-dev. On Mon, 2015-04-20 at 14:02 +0200, Severin Gehwolf wrote: Hi, Could I please get a review and a sponsor for the following patch? The issue is tha

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-20 Thread Severin Gehwolf
On Mon, 2015-04-20 at 12:24 -0400, Andrew Hughes wrote: > - Original Message - > > Adding in net-dev. > > > > On Mon, 2015-04-20 at 14:02 +0200, Severin Gehwolf wrote: > > > Hi, > > > > > > Could I please get a review and a sponsor for the following patch? > > > > > > The issue is that J

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-20 Thread Andrew Hughes
- Original Message - > Adding in net-dev. > > On Mon, 2015-04-20 at 14:02 +0200, Severin Gehwolf wrote: > > Hi, > > > > Could I please get a review and a sponsor for the following patch? > > > > The issue is that JDK's internal /etc/resolv.conf nameserver parsing > > does not properly ac

Re: RFR(xs): 6991580: IPv6 Nameservers in resolv.conf throws NumberFormatException

2015-04-20 Thread Severin Gehwolf
Adding in net-dev. On Mon, 2015-04-20 at 14:02 +0200, Severin Gehwolf wrote: > Hi, > > Could I please get a review and a sponsor for the following patch? > > The issue is that JDK's internal /etc/resolv.conf nameserver parsing > does not properly account for IPv6 addresses on Linux/Unix. While t