RE: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

2016-05-12 Thread Langer, Christoph
Looks nice, thanks :) > -Original Message- > From: Chris Hegarty [mailto:chris.hega...@oracle.com] > Sent: Donnerstag, 12. Mai 2016 17:36 > To: Langer, Christoph > Cc: net-dev@openjdk.java.net > Subject: Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

2016-05-12 Thread Chris Hegarty
ristoph > > >> -Original Message- >> From: Chris Hegarty [mailto:chris.hega...@oracle.com] >> Sent: Donnerstag, 12. Mai 2016 12:43 >> To: Langer, Christoph >> Cc: Alan Bateman ; Dmitry Samersoff >> ; Mark Sheppard >> ; net-dev@openjdk.java.net >&

RE: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

2016-05-12 Thread Langer, Christoph
ge- > From: Chris Hegarty [mailto:chris.hega...@oracle.com] > Sent: Donnerstag, 12. Mai 2016 12:43 > To: Langer, Christoph > Cc: Alan Bateman ; Dmitry Samersoff > ; Mark Sheppard > ; net-dev@openjdk.java.net > Subject: Re: RFR(S): 8156521: Minor Fixes and cleanups in Networ

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

2016-05-12 Thread Chris Hegarty
2016 12:25 >> To: Langer, Christoph >> Cc: Alan Bateman ; Dmitry Samersoff >> ; net-dev@openjdk.java.net >> Subject: Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c >> >> >> On 11 May 2016, at 10:21, Langer, Christoph >> wrote:

RE: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

2016-05-11 Thread Langer, Christoph
ttwoch, 11. Mai 2016 12:25 > To: Langer, Christoph > Cc: Alan Bateman ; Dmitry Samersoff > ; net-dev@openjdk.java.net > Subject: Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c > > > On 11 May 2016, at 10:21, Langer, Christoph > wrote: > >

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

2016-05-11 Thread Mark Sheppard
the declaration in of plen (also scope and dad_status) as an int in enumIPv6Interfaces would appear to be done to align with its use in fscanf, even though it is a two character conversion. So would it not be more appropriate to cast it as a short when passed to addif ? the name plen would als

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

2016-05-11 Thread Chris Hegarty
On 11 May 2016, at 10:21, Langer, Christoph wrote: > Hi, > > @Chris: As for your points: > >> I agree with the replacement of strcpy with strncpy, but I think we should >> explicitly null terminate in case the src is greater or equal to the dst >> buffer >> size. This is done elsewhere in thi

RE: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

2016-05-11 Thread Langer, Christoph
Hi, @Chris: As for your points: > I agree with the replacement of strcpy with strncpy, but I think we should > explicitly null terminate in case the src is greater or equal to the dst > buffer > size. This is done elsewhere in this file too, e.g. > >strncpy(buf, input, sizeof(buf) - 1); >

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

2016-05-11 Thread Alan Bateman
On 11/05/2016 09:50, Chris Hegarty wrote: Hi Christoph, On 11 May 2016, at 08:43, Dmitry Samersoff wrote: ... bugreport: https://bugs.openjdk.java.net/browse/JDK-8156521 webrev: http://cr.openjdk.java.net/~clanger/webrevs/8156521.0/ I think this is mainly fine, and good to have such clean

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

2016-05-11 Thread Chris Hegarty
Hi Christoph, On 11 May 2016, at 08:43, Dmitry Samersoff wrote: >> ... >> bugreport: https://bugs.openjdk.java.net/browse/JDK-8156521 >> >> webrev: http://cr.openjdk.java.net/~clanger/webrevs/8156521.0/ I think this is mainly fine, and good to have such cleanup in this area. I agree with the

Re: RFR(S): 8156521: Minor Fixes and cleanups in NetworkInterface.c

2016-05-11 Thread Dmitry Samersoff
Christoph, Looks good for me (Reviewed). Few more space nits (no need to re-review) 1141 Missed space around = in i=0 1890 extra space after ( 2068 wrong indent -Dmitry On 2016-05-10 12:54, Langer, Christoph wrote: > Hi all, > > > > can I please get a review for a change to NetworkInter