2 3:08:57 PM GMT -05:00 US/Canada Eastern
> Subject: Re: Proposed changes for Bug 7193520
>
> John,
>
> Changes look good for me.
> Few nits below.
>
>
> PlainDatagramSocketImpl.c
>
>
> 318 brackets is not necessary anymore
>
> 1644 whole #ifde
On 14/09/2012 19:22, John Zavgren wrote:
:
The proposed changes to the code
(http://cr.openjdk.java.net/~chegar/7193520/webrev.00/) eliminate distracting
dead wood, and it makes it run (slightly) faster, because the run time checks
are eliminated.
It's good to remove this old and long unused
changes for Bug 7193520
John,
Changes look good for me.
Few nits below.
PlainDatagramSocketImpl.c
318 brackets is not necessary anymore
1644 whole #ifdef could be removed
struct ip_mreqn mreqn;
is not necessary anymore,
2283 the same
2294 #ifdef is not necessary anymore
--- This
Thanks.
- Original Message -
From: dmitry.samers...@oracle.com
To: john.zavg...@oracle.com
Cc: net-dev@openjdk.java.net
Sent: Friday, September 14, 2012 3:08:57 PM GMT -05:00 US/Canada Eastern
Subject: Re: Proposed changes for Bug 7193520
John,
Changes look good for me.
Few nits below
John,
Changes look good for me.
Few nits below.
PlainDatagramSocketImpl.c
318 brackets is not necessary anymore
1644 whole #ifdef could be removed
struct ip_mreqn mreqn;
is not necessary anymore,
2283 the same
2294 #ifdef is not necessary anymore
-Dmitry
On 2012-09-14 22:2
