Re: [External] : Re: Proposal - 8209137: Add ability to bind to specific local address to HTTP client

2021-12-13 Thread Jaikiran Pai
The main items that we discussed in this thread have now all been included in the PR, so I've opened it for a formal review through a RFR. -Jaikiran On 08/12/21 8:51 pm, Jaikiran Pai wrote: Hello Daniel, On 08/12/21 8:21 pm, Daniel Fuchs wrote: Hi Jaikiran, On 08/12/2021 14:32, Jaikiran Pai

Re: Proposal - 8209137: Add ability to bind to specific local address to HTTP client

2021-12-03 Thread Michael McMahon
Yes, I agree with this. It's a niche use case which should be made clear in the docs. The new method should have a default implementation. I think I prefer also to use a SocketAddress in case there is some future need to also specify the local port. The InetSocketAddress constructors allow a

Re: Proposal - 8209137: Add ability to bind to specific local address to HTTP client

2021-12-03 Thread Jaikiran Pai
Hello Daniel, On 03/12/21 5:59 pm, Daniel Fuchs wrote: Hi Jaikiran, A couple of remarks: > However, in this specific case the Builder is expected > to be created using the static java.net.http.HTTPClient.newBuilder() > method and that implementation always returns an internal implementation

Re: Proposal - 8209137: Add ability to bind to specific local address to HTTP client

2021-12-03 Thread Daniel Fuchs
Hi Jaikiran, A couple of remarks: > However, in this specific case the Builder is expected > to be created using the static java.net.http.HTTPClient.newBuilder() > method and that implementation always returns an internal implementation > of the Builder interface. That effectively means that the