Thank you Chris
-Shirish
On 8/13/2012 6:24 PM, Chris Hegarty wrote:
On 13/08/2012 13:36, Shirish Kuncolienkar wrote:
Chris,
Thank you. Could you please push the changes ?
Done.
http://hg.openjdk.java.net/jdk8/tl/jdk/rev/399c2adf3ad6
Thanks for the contribution Shirish.
-Chris.
Thanks
Shi
On 13/08/2012 13:36, Shirish Kuncolienkar wrote:
Chris,
Thank you. Could you please push the changes ?
Done.
http://hg.openjdk.java.net/jdk8/tl/jdk/rev/399c2adf3ad6
Thanks for the contribution Shirish.
-Chris.
Thanks
Shirish
On 8/10/2012 9:39 PM, Chris Hegarty wrote:
Shirish,
There wer
Chris,
Thank you. Could you please push the changes ?
Thanks
Shirish
On 8/10/2012 9:39 PM, Chris Hegarty wrote:
Shirish,
There were some minor issues with your patch ( it did not build on all
platforms ). I fixed these issues and also updated the Mac variant of
getFlags. It now compiles an
Shirish,
There were some minor issues with your patch ( it did not build on all
platforms ). I fixed these issues and also updated the Mac variant of
getFlags. It now compiles and runs on all platforms.
The test has been dropped ( as I indicated in the previous mail ).
http://cr.openjdk.java
Chris,
Please go ahead and run the sanity builds and tests.
Thanks
-Shirish
On 8/9/2012 7:52 PM, Chris Hegarty wrote:
On 09/08/12 14:16, Shirish Kuncolienkar wrote:
I agree there is no general documentation available, AIX defines vipa
interface flag as "0x8000"
In which case I don
On 09/08/12 14:16, Shirish Kuncolienkar wrote:
I agree there is no general documentation available, AIX defines vipa
interface flag as "0x8000"
In which case I don't see any problems with your proposed source
changes. One could argue that maybe they should go through the specific
po
On 8/9/2012 4:55 PM, Chris Hegarty wrote:
Shirish,
I am not familiar with VIPA interfaces, but I don't see any
documentation that describes allowable values for flags that could
cause the integer representing it to contain a negative value.
I'm not opposed to the source changes, I just don't
Shirish,
I am not familiar with VIPA interfaces, but I don't see any
documentation that describes allowable values for flags that could cause
the integer representing it to contain a negative value.
I'm not opposed to the source changes, I just don't see that they are
required. Can you pleas
