Re: PING: Re: RFR: JDK-8184770: JDWP support for IPv6

2019-05-15 Thread Chris Hegarty
Alex, On 13/05/2019 22:06, Alex Menkov wrote: Hi Chris, Serguei, Updated webrev: http://cr.openjdk.java.net/~amenkov/IPv6/webrev.05/ I'm ok with this version. CSR (approved): https://bugs.openjdk.java.net/browse/JDK-8223104 Changes (vs. webrev.04): - setsockopt(IPV6_V6ONLY) was moved from

Re: PING: Re: RFR: JDK-8184770: JDWP support for IPv6

2019-05-13 Thread serguei.spit...@oracle.com
Hi Alex, Thank you for the update! It looks good to me. Thanks, Serguei On 5/13/19 14:06, Alex Menkov wrote: Hi Chris, Serguei, Updated webrev: http://cr.openjdk.java.net/~amenkov/IPv6/webrev.05/ CSR (approved): https://bugs.openjdk.java.net/browse/JDK-8223104 Changes (vs. webrev.04): - se

Re: PING: Re: RFR: JDK-8184770: JDWP support for IPv6

2019-05-13 Thread Alex Menkov
Hi Chris, Serguei, Updated webrev: http://cr.openjdk.java.net/~amenkov/IPv6/webrev.05/ CSR (approved): https://bugs.openjdk.java.net/browse/JDK-8223104 Changes (vs. webrev.04): - setsockopt(IPV6_V6ONLY) was moved from Win-specific code to shared setOptionsCommon function (in socketTransport.c)

Re: PING: Re: RFR: JDK-8184770: JDWP support for IPv6

2019-05-11 Thread Chris Hegarty
> On 7 May 2019, at 19:40, serguei.spit...@oracle.com wrote: > > Hi guys, > > We need a couple of partial reviews for this enhancement: > > - From the net-dev to check IPv6-addresses related part. >It does not need to be a thorough review. >We need another pair of eyes to check for o