Re: Crash problem in net.dll

2011-09-07 Thread Jonathan Lu
Aha, got it, thanks! Jonathan. On 09/07/2011 04:19 PM, Michael McMahon wrote: Jonathan, The tests were fine amd the fix was pushed last week. Michael. On 07/09/11 09:14, Jonathan Lu wrote: Hi Michael, Any news about the testing results of this patch? Thanks Jonathan On 08/29/2011 11:02 P

Re: Crash problem in net.dll

2011-09-07 Thread Michael McMahon
Jonathan, The tests were fine amd the fix was pushed last week. Michael. On 07/09/11 09:14, Jonathan Lu wrote: Hi Michael, Any news about the testing results of this patch? Thanks Jonathan On 08/29/2011 11:02 PM, Michael McMahon wrote: Just to be clear, I will run the tests on the fix and

Re: Crash problem in net.dll

2011-09-07 Thread Jonathan Lu
Hi Michael, Any news about the testing results of this patch? Thanks Jonathan On 08/29/2011 11:02 PM, Michael McMahon wrote: Just to be clear, I will run the tests on the fix and push the change assuming everything is ok. There is a webrev here http://cr.openjdk.java.net/~michaelm/7084560/webr

Re: Crash problem in net.dll

2011-08-29 Thread Michael McMahon
Just to be clear, I will run the tests on the fix and push the change assuming everything is ok. There is a webrev here http://cr.openjdk.java.net/~michaelm/7084560/webrev.1/ Thanks, Michael. On 29/08/11 15:33, Michael McMahon wrote: Jonathan, Bug id 7084560 has been created to track this. Tha

Re: Crash problem in net.dll

2011-08-29 Thread Michael McMahon
Jonathan, Bug id 7084560 has been created to track this. That fix looks fine to me. Thanks, Michael. On 29/08/11 10:20, Jonathan Lu wrote: Hi Michael, Thanks for reminding, I checked the source under src/windows folder and found two more places to change. Here's the updated patch: diff -r

Re: Crash problem in net.dll

2011-08-29 Thread Jonathan Lu
Hi Michael, Thanks for reminding, I checked the source under src/windows folder and found two more places to change. Here's the updated patch: diff -r 9b8c96f96a0f src/windows/native/java/net/NetworkInterface.c --- a/src/windows/native/java/net/NetworkInterface.cMon Jun 27 13:21:34 2011

Re: Crash problem in net.dll

2011-08-29 Thread Michael McMahon
Jonathan, I think the change looks reasonable. But, we should make the equivalent change at the other site where enumAddresses_win() is called in the same file. - Michael. On 29/08/11 09:14, Jonathan Lu wrote: Hello everybody, I got one crash issue on OpenJDK7 windows build. I captured the