Re: Code review request: 7059542 JNDI name operations should be locale independent

The code changes look fine, and thanks for including the sun/security/{tools,krb5} codes. -Max On 08/28/2011 06:36 PM, Xuelei Fan wrote: Hi Weijun, Would you please review the new update? I also include the changes in security components. webrev: webrev: http://cr.openjdk.java.net/~xuelei/7

Re: Code review request: 7059542 JNDI name operations should be locale independent

Hi Weijun, Would you please review the new update? I also include the changes in security components. webrev: webrev: http://cr.openjdk.java.net/~xuelei/7059542/webrev.01/ Thanks, Xuelei On 8/1/2011 9:48 AM, Xuelei Fan wrote: > Hi Weijun, > > Please pending the code review. Another thread is a

Re: Code review request: 7059542 JNDI name operations should be locale independent

Hi Weijun, Please pending the code review. Another thread is addressing the warning issues in JNDI, I will wait for a while to remove the warning update from this fix. Thanks, Xuelei On 7/30/2011 9:52 PM, Xuelei Fan wrote: > Hi Weijun, > > It was "test/javax/naming/ldap/LdapName/CompareToEquals

Re: Code review request: 7059542 JNDI name operations should be locale independent

Hi Weijun, It was "test/javax/naming/ldap/LdapName/CompareToEqualsTests fails intermittently". I updated the synopsis to "JNDI name operations should be locale independent" when found the underlying failure problem. Would you please review the JNDI update when you available? The fix also include

Re: Code review request: 7059542 JNDI name operations should be locale independent

Ping ... Xuelei On 7/21/2011 3:26 PM, Xuelei Fan wrote: > Hi, > > In JNDI implementation, String.toUpperCase() and String.toLowerCase() is > used to compare or hashcode case-insensitive strings. These operations > are locale dependent, and may result in unexpected behaviors in some > locale.[1]