Re: Code review 6870935

2009-10-01 Thread Michael McMahon
Chris, Thanks. Agreed, except 5) is like that because a response body follows the response headers - Michael. Christopher Hegarty -Sun Microsystems Ireland wrote: The actual changes look fine. I have just a few comments/questions about the test: 1) copyright year should be updated to 2009 2)

Re: Code review 6870935

2009-10-01 Thread Christopher Hegarty -Sun Microsystems Ireland
The actual changes look fine. I have just a few comments/questions about the test: 1) copyright year should be updated to 2009 2) I don't think s1 needs to be a field. I think it should be a local in run. 3) Indentation of run looks a little too far. 4) error should be volatile. 5) I would hav