Re: Code Review Request: 8020498: Crash when both libnet.so and libmawt.so are loaded

2013-07-18 Thread Chris Hegarty
On 18 Jul 2013, at 19:14, Kurchi Hazra wrote: > Alright, I'll add it before asking for approval from 7u-dev. > > - Kurchi > > On 7/18/2013 11:11 AM, Dmitry Samersoff wrote: >> Kurchi, >> >> As you don't plan to use this function outside of net_util.c it's better >> to add static keyword as we

Re: Code Review Request: 8020498: Crash when both libnet.so and libmawt.so are loaded

2013-07-18 Thread Kurchi Hazra
Alright, I'll add it before asking for approval from 7u-dev. - Kurchi On 7/18/2013 11:11 AM, Dmitry Samersoff wrote: Kurchi, As you don't plan to use this function outside of net_util.c it's better to add static keyword as well. -Dmitry On 2013-07-18 21:55, Kurchi Hazra wrote: Hi Chris, Th

Re: Code Review Request: 8020498: Crash when both libnet.so and libmawt.so are loaded

2013-07-18 Thread Dmitry Samersoff
Kurchi, As you don't plan to use this function outside of net_util.c it's better to add static keyword as well. -Dmitry On 2013-07-18 21:55, Kurchi Hazra wrote: > Hi Chris, > > Thanks for the additional information. How about this fix: > http://cr.openjdk.java.net/~khazra/8020498/webrev.01/ >

Re: Code Review Request: 8020498: Crash when both libnet.so and libmawt.so are loaded

2013-07-18 Thread Kurchi Hazra
Hi Chris, Thanks for the additional information. How about this fix: http://cr.openjdk.java.net/~khazra/8020498/webrev.01/ - Kurchi On 7/18/2013 2:44 AM, Chris Hegarty wrote: On 18/07/2013 01:19, Kurchi Hazra wrote: Hi, We are seeing a crash when both libmawt.so and libnet.so are loaded,

Re: Code Review Request: 8020498: Crash when both libnet.so and libmawt.so are loaded

2013-07-18 Thread Chris Hegarty
On 18/07/2013 01:19, Kurchi Hazra wrote: Hi, We are seeing a crash when both libmawt.so and libnet.so are loaded, and the init() method in src/share/native/java/net/net_util.c is called, but an init() method in libmawt.so gets invoked instead. Although it is difficult to reproduce the problem,