Re: 8248865: Document JNDI/LDAP timeout properties

2020-07-07 Thread Daniel Fuchs
On 07/07/2020 14:08, Sean Mullan wrote: I believe this is a more general problem - and I would beg to tackle that in a followup issue if you don't mind. Ok. For the record I have logged https://bugs.openjdk.java.net/browse/JDK-8248909 best regards, -- daniel

Re: 8248865: Document JNDI/LDAP timeout properties

2020-07-07 Thread Sean Mullan
On 7/7/20 9:02 AM, Daniel Fuchs wrote: Hi Sean, Good point. It appears it throws a java.lang.NumberFormatException which is not documented as being thrown by any InitialContext constructors or its subclasses, nor by `addToEnvironment`. Ugh, ok. I believe this is a more general problem - and

Re: 8248865: Document JNDI/LDAP timeout properties

2020-07-07 Thread Daniel Fuchs
Hi Sean, Good point. It appears it throws a java.lang.NumberFormatException which is not documented as being thrown by any InitialContext constructors or its subclasses, nor by `addToEnvironment`. I believe this is a more general problem - and I would beg to tackle that in a followup issue if y

Re: 8248865: Document JNDI/LDAP timeout properties

2020-07-07 Thread Sean Mullan
You should document what the behavior is if an invalid string value is set (ex: not an integer). --Sean On 7/7/20 7:11 AM, Aleks Efimov wrote: Hi Daniel, Thanks for documenting the system properties. It looks good to me. NIT: You might want to update the copyright's last modification year to

Re: 8248865: Document JNDI/LDAP timeout properties

2020-07-07 Thread Chris Hegarty
Looks ok to me. -Chris. > On 6 Jul 2020, at 16:39, Daniel Fuchs wrote: > > Hi, > > Please find below a doc only change to document two > JDK specific JNDI/LDAP timeout properties: > > 8248865: Document JNDI/LDAP timeout properties > https://bugs.openjdk.java.net/browse/JDK-8248865 > > webrev

Re: 8248865: Document JNDI/LDAP timeout properties

2020-07-07 Thread Aleks Efimov
Hi Daniel, Thanks for documenting the system properties. It looks good to me. NIT: You might want to update the copyright's last modification year to 2020 Best Regards, Aleksei On 06/07/2020 16:39, Daniel Fuchs wrote: Hi, Please find below a doc only change to document two JDK specific JNDI/