Re: 8217451: ExtendedSocketOptions should encapsulate support for SO_FLOW_SLA

2019-01-21 Thread Alan Bateman
On 21/01/2019 18:00, Michael McMahon wrote: Hi Alan, Looks fine apart from extra space on line 85: ExtendedSocketOptions.java Thanks, I'll fix that before pushing. -Alan

Re: 8217451: ExtendedSocketOptions should encapsulate support for SO_FLOW_SLA

2019-01-21 Thread Chris Hegarty
On 21/01/2019 17:41, Alan Bateman wrote: ExtendSocketOptions is the supporting class that the socket implementations use for JDK-specific socket options. Vyom improved it last year to select options based on the socket type but more is needed to handle socket options that are specific to conn

Re: 8217451: ExtendedSocketOptions should encapsulate support for SO_FLOW_SLA

2019-01-21 Thread Michael McMahon
Hi Alan, Looks fine apart from extra space on line 85: ExtendedSocketOptions.java - Michael. On 21/01/2019, 17:41, Alan Bateman wrote: ExtendSocketOptions is the supporting class that the socket implementations use for JDK-specific socket options. Vyom improved it last year to select options