Re: 6563286: HttpURLConnection.followRedirect(..) follows malformed url.

2013-06-27 Thread Andreas Rieber
Hi, i did one more update to avoid duplicate code (3 times used). The redirect status codes are checked now in one static method. I added "Malformed redirect" to the exception, so it is possible to trace. All tests run on ubuntu. Updated webrev: http://cr.openjdk.java.net/~arieber/6563286/we

Re: 6563286: HttpURLConnection.followRedirect(..) follows malformed url.

2013-06-26 Thread Andreas Rieber
Hi Kurchi, i removed the closed issue. Then i checked again the HttpURLConnection and moved the check so really only redirects are detected and handled properly with the IOException. The test i updated and moved to the right place. Bug: http://bugs.sun.com/view_bug.do?bug_id=6563286 Updated

Re: 6563286: HttpURLConnection.followRedirect(..) follows malformed url.

2013-06-25 Thread Andreas Rieber
Hi Kurchi, thanks for the first feedback. The problem i had was that the URL is right (according spec) but at protocol level the used URI is wrong. The ProxySelector is also right to send the IllegalArgumentException (just needed to be documented to do that). And yes, a better error message s

Re: 6563286: HttpURLConnection.followRedirect(..) follows malformed url.

2013-06-25 Thread Kurchi Hazra
Hi Andreas, Your changes look good to me. 5069130 had been closed as not a defect - since we throw an unchecked exception, and was decided to be the right course of action. Now, I don't have a problem with changing the code to throw a checked exception in this case - but we have to wait fo