On 17/09/18 11:56, Hamlin Li wrote:
Hi Chris,
Thank you for review. I agree with you.
I think we only need to address the issue in EchoHandler.java, where the
temp file is created in default path rather than the path in test scratch.
updated webrev: http://cr.openjdk.java.net/~mli/8210802/we
ly
blocks? But I guess one can do it with deleteOnExit() as well...
Best regards
Christoph
-Original Message-
From: net-dev On Behalf Of
Hamlin Li
Sent: Montag, 17. September 2018 07:55
To: OpenJDK Network Dev list
Subject: RFR of JDK-8210802,temp files left by tests in
jd
do it with deleteOnExit() as well...
Best regards
Christoph
-Original Message-
From: net-dev On Behalf Of
Hamlin Li
Sent: Montag, 17. September 2018 07:55
To: OpenJDK Network Dev list
Subject: RFR of JDK-8210802,temp files left by tests in
jdk/java/net/httpclient
Would you please
018 11:02
> To: Langer, Christoph
> Cc: OpenJDK Network Dev list
> Subject: Re: RFR of JDK-8210802,temp files left by tests in
> jdk/java/net/httpclient
>
> Hi Christoph,
>
> Thank you for review.
>
> Normally I prefer to use "finally" too.
>
> Bu
xit() as well...
Best regards
Christoph
-Original Message-
From: net-dev On Behalf Of Hamlin Li
Sent: Montag, 17. September 2018 07:55
To: OpenJDK Network Dev list
Subject: RFR of JDK-8210802,temp files left by tests in jdk/java/net/httpclient
Would you please review the following patch?
b
018 07:55
> To: OpenJDK Network Dev list
> Subject: RFR of JDK-8210802,temp files left by tests in
> jdk/java/net/httpclient
>
> Would you please review the following patch?
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8210802
> webrev: http://cr.openjdk.java.net/~mli/8210802/webrev.00/
>
> Thank you
> -Hamlin
Would you please review the following patch?
bug: https://bugs.openjdk.java.net/browse/JDK-8210802
webrev: http://cr.openjdk.java.net/~mli/8210802/webrev.00/
Thank you
-Hamlin
