On 16/03/2018 09:00, Hamlin Li wrote:
:
Just to confirm, have you run the serviceability and http client
tests to make sure that they compile with this change?
Yes, I ran tier1,tier2,tier3 tests(I think it includes httpclient
tests), and also specific tests using Utils.getFreePort in svc ar
On 16/03/2018 4:05 PM, Alan Bateman wrote:
On 16/03/2018 01:54, Hamlin Li wrote:
:
Hi Alan,
Thank you for detailed reviewing. I have updated the webrev in place.
(http://cr.openjdk.java.net/~mli/8199215/webrev.00/)
Looks good, just a minor typo "is better choice" -> "is a better choice".
Hi
On 16/03/2018 01:54, Hamlin Li wrote:
:
Hi Alan,
Thank you for detailed reviewing. I have updated the webrev in place.
(http://cr.openjdk.java.net/~mli/8199215/webrev.00/)
Looks good, just a minor typo "is better choice" -> "is a better choice".
Just to confirm, have you run the serviceabilit
On 15/03/2018 7:20 PM, Alan Bateman wrote:
On 15/03/2018 08:43, Hamlin Li wrote:
:
Hi Alan,
Thank you for reviewing, I have updated the webrev in place.
( cc'ing serviceability-dev and net-dev as these are the other areas
that use the getFreePort method in the test library. For context, the
On 15/03/2018 08:43, Hamlin Li wrote:
:
Hi Alan,
Thank you for reviewing, I have updated the webrev in place.
( cc'ing serviceability-dev and net-dev as these are the other areas
that use the getFreePort method in the test library. For context, the
patch that we are discussing is:
http:/
