Re: RFR of JDK-8158881: Doc typo in src/../java/net/URI.java

2016-06-08 Thread Bradford Wetmore
Looks good, thanks. brad On 6/8/2016 1:16 AM, Chris Hegarty wrote: On 8 Jun 2016, at 03:36, Hamlin Li wrote: On 2016/6/8 4:27, Bradford Wetmore wrote: May I suggest using example.com [1] and an arbitrary path instead on these two examples, so that there's no chance of it being mistaken fo

Re: RFR of JDK-8158881: Doc typo in src/../java/net/URI.java

2016-06-08 Thread Chris Hegarty
On 8 Jun 2016, at 03:36, Hamlin Li wrote: > > On 2016/6/8 4:27, Bradford Wetmore wrote: >> May I suggest using example.com [1] and an arbitrary path instead on these >> two examples, so that there's no chance of it being mistaken for a valid >> URL. This example uses old hostnames that might c

Re: RFR of JDK-8158881: Doc typo in src/../java/net/URI.java

2016-06-07 Thread Hamlin Li
On 2016/6/8 4:27, Bradford Wetmore wrote: May I suggest using example.com [1] and an arbitrary path instead on these two examples, so that there's no chance of it being mistaken for a valid URL. This example uses old hostnames that might change yet again (docs.oracle.com) and an ancient JDK pl

Re: RFR of JDK-8158881: Doc typo in src/../java/net/URI.java

2016-06-07 Thread Bradford Wetmore
May I suggest using example.com [1] and an arbitrary path instead on these two examples, so that there's no chance of it being mistaken for a valid URL. This example uses old hostnames that might change yet again (docs.oracle.com) and an ancient JDK platform (1.3), let's just remove that confu

Re: RFR of JDK-8158881: Doc typo in src/../java/net/URI.java

2016-06-07 Thread Hamlin Li
On 2016/6/7 17:34, Chris Hegarty wrote: On 7 Jun 2016, at 05:50, Hamlin Li wrote: Would you please review the following simple doc patch? bug: https://bugs.openjdk.java.net/browse/JDK-8158881 webrev: http://cr.openjdk.java.net/~mli/8158881/webrev.00/ I’m not sure why the URL’s were ever chan

Re: RFR of JDK-8158881: Doc typo in src/../java/net/URI.java

2016-06-07 Thread Chris Hegarty
> On 7 Jun 2016, at 05:50, Hamlin Li wrote: > > Would you please review the following simple doc patch? > > bug: https://bugs.openjdk.java.net/browse/JDK-8158881 > webrev: http://cr.openjdk.java.net/~mli/8158881/webrev.00/ I’m not sure why the URL’s were ever changed from java.sun.com, since t

RFR of JDK-8158881: Doc typo in src/../java/net/URI.java

2016-06-06 Thread Hamlin Li
Would you please review the following simple doc patch? bug: https://bugs.openjdk.java.net/browse/JDK-8158881 webrev: http://cr.openjdk.java.net/~mli/8158881/webrev.00/ Thank you -Hamlin --- a/src/java.base/share/classes/java/net/URI.javaTue Jun 07 10:33:38 2016 +0800 +++ b/src/java.base/