+1,
Thanks, Roger
On 6/8/2016 9:13 AM, Pavel Rappo wrote:
On 7 Jun 2016, at 18:42, Roger Riggs wrote:
Hi Pavel,
Looks fine.
WebSocket.java:
- line 82: I'd replace 'never' with 'does not'; it is more like a statement
for fact and less a guarantee.
- LIne 54: The notation "{@code .onX}" se
> On 7 Jun 2016, at 18:42, Roger Riggs wrote:
>
> Hi Pavel,
>
> Looks fine.
>
> WebSocket.java:
> - line 82: I'd replace 'never' with 'does not'; it is more like a statement
> for fact and less a guarantee.
>
> - LIne 54: The notation "{@code .onX}" seems unnecessary, is quite cryptic,
> a
Hi Pavel,
Looks fine.
WebSocket.java:
- line 82: I'd replace 'never' with 'does not'; it is more like a
statement for fact and less a guarantee.
- LIne 54: The notation "{@code .onX}" seems unnecessary, is quite
cryptic, and can be removed.
Are there any tests that would be updated to g
Hi,
Could you please review the following change for JDK-8156693?
http://cr.openjdk.java.net/~prappo/8156693/webrev.01/
This change addresses some WebSocket API refinements and enhancements from [1].
WebSocket returns `CompletableFuture` from some of its methods. CFs are used by
an implementati
