Re: RFR 8244652: Add test for non utf-8 response handling by websocket client

Thanks Daniel I would proceed with the push if there are no further comments. On 13/05/2020, 12:39, "Daniel Fuchs" wrote: Hi Rahul, That looks good to me thanks! I am still teetering on whether we should also have altered the specification of WSHandshakeException, and

Re: RFR 8244652: Add test for non utf-8 response handling by websocket client

Hi Rahul, That looks good to me thanks! I am still teetering on whether we should also have altered the specification of WSHandshakeException, and explicitly changed the signature of WSHandshakeException::getResponse to return an HttpResponse instead of an HttpResponse. On the one hand - our im

RFR 8244652: Add test for non utf-8 response handling by websocket client

  Hello, Request to have my fix reviewed for the issue: JDK-8244652: Add test for non utf-8 response handling by websocket client. The test java.net.httpclient.websocket.WSHandshakeExceptionTest.java is updated to test   that the websocket client handles invalid utf-8 sent b