On 06/05/2020 16:48, rahul.r.ya...@oracle.com wrote:
Thanks Daniel , webrev updated.
Looks good!
-- daniel
Thanks Daniel , webrev updated.
- rahul
On 06/05/2020 16:16, Daniel Fuchs wrote:
Hi Rahul,
LGTM.
111 WebSocketHandshakeException wse =
(WebSocketHandshakeException) t;
112 out.println("Status code is " +
wse.getResponse().statusCode());
113
> On 6 May 2020, at 16:16, Daniel Fuchs wrote:
>
> Hi Rahul,
>
> LGTM.
+1
-Chris.
Hi Rahul,
LGTM.
111 WebSocketHandshakeException wse =
(WebSocketHandshakeException) t;
112 out.println("Status code is " +
wse.getResponse().statusCode());
113 out.println("Response is " +
wse.getResponse().body());
114 asse
Hi Pavel,
Thank you for the comment, the webrev has been updated.
webrev : http://cr.openjdk.java.net/~ryadav/webrev_8240666/webrev.00/index.html
- rahul
On 06/05/2020, 14:26, "Pavel Rappo" wrote:
An assertion of the form
assertEquals(true, ((String)wse.getResponse().body())
An assertion of the form
assertEquals(true, ((String)wse.getResponse().body()).contains("404"));
looks odd. I'd suggest using any of
assertTrue(boolean condition)
assertTrue(boolean condition, String message)
-Pavel
> On 6 May 2020, at 14:12, Rahul wrote:
>
> http://cr.openjdk.ja
Hello,
Request to have my fix reviewed for the issue:
JDK-8240666: Websocket client’s OpeningHandshake discards the HTTP response
body.
The fix updates jdk.internal.net.http.websocket.OpeningHandshake.send()
to process the response body received from server instead of di
