Hi Daniel,
thanks for the review, i pushed the change(https://hg.openjdk.java.net/jdk/jdk/rev/ca2dcaf37fad).
Thanks,
Vyom
- Original message -From: Daniel Fuchs To: Vyom Tewari26 Cc: core-libs-...@openjdk.java.net, net-dev@openjdk.java.net, vyomm...@gmail.comSubject: [EXTERNAL] Re: RF
Hi Daniel,
Thanks for the review i need a favor , as my OpenJDK(vtewari) id is not working so i can not push the code.
Can you please push the code once review is done.
Thanks,
Vyom
- Original message -From: Daniel Fuchs To: Vyom Tewari26 Cc: core-libs-...@openjdk.java.net, net-de
Hi Vyom,
I tried out your patch and got no suspicious failures so
you have my review :-)
best regards,
-- daniel
On 15/02/2020 04:14, Vyom Tewari26 wrote:
I'll get back to you when I have managed to find some
cycles to do so.
best regards,
-- daniel
On 14/02/2020 04:57, Vyom Tiwari wrote:
Sounds good
Thanks,
Vyom
- Original message -From: Daniel Fuchs Sent by: "net-dev" To: Vyom Tiwari , net-dev , core-libs-dev Cc:Subject: [EXTERNAL] Re: RFR 8238579: HttpsURLConnection drops the timeout and hangs forever in readDate: Sat, Feb 15, 2020 1:11 AM
Hi Vyom,On the surface, your
Hi Vyom,
On the surface, your patch seems reasonable.
I would be more confident if there was a test, but I understand
it might well be one of these noreg-hard issues.
I've put it on my TODO list to import your patch and
try to test it in our test system.
I'll get back to you when I have managed
resolved.
Thanks,
Vyom
- Original message -From: "felixxfyang(杨晓峰)" Sent by: "core-libs-dev" To: Vyom Tiwari , net-dev , core-libs-dev Cc:Subject: [EXTERNAL] Re: RFR 8238579: HttpsURLConnection drops the timeout and hangs forever in read(Internet mail)Date: Fri, Feb 14, 20
Hi All,
Please find the below fix which resolves the issue(
https://bugs.openjdk.java.net/browse/JDK-8238579).
"HttpURLConnection.writeRequests()" retry in case of any write failure,
during retry it creates new HttpsClient without connectTimeout &
readTimeout. Below fix sets the connect & read
