Re: RFR 8220598: Malformed copyright year range in a few files in java.base

2019-03-13 Thread Weijun Wang
+1 (on the security class). Thanks, Max > On Mar 14, 2019, at 1:10 AM, Lance Andersen wrote: > > +1 >> On Mar 13, 2019, at 1:04 PM, Chris Hegarty wrote: >> >> Trivially, there should be a comma after the year. Just add it. >> >> >> $ hg diff src/java.base/share/classes/jdk/ src/java.base/sh

Re: RFR 8220598: Malformed copyright year range in a few files in java.base

2019-03-13 Thread Lance Andersen
+1 > On Mar 13, 2019, at 1:04 PM, Chris Hegarty wrote: > > Trivially, there should be a comma after the year. Just add it. > > > $ hg diff src/java.base/share/classes/jdk/ src/java.base/share/classes/sun > diff --git a/src/java.base/share/classes/jdk/internal/util/ArraysSupport.java > b/src/ja

Re: RFR 8220598: Malformed copyright year range in a few files in java.base

2019-03-13 Thread Daniel Fuchs
Looks good to me Chris! cheers, -- daniel On 13/03/2019 17:04, Chris Hegarty wrote: Trivially, there should be a comma after the year. Just add it.

RFR 8220598: Malformed copyright year range in a few files in java.base

2019-03-13 Thread Chris Hegarty
Trivially, there should be a comma after the year. Just add it. $ hg diff src/java.base/share/classes/jdk/ src/java.base/share/classes/sun diff --git a/src/java.base/share/classes/jdk/internal/util/ArraysSupport.java b/src/java.base/share/classes/jdk/internal/util/ArraysSupport.java --- a/src/ja