Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths

2018-12-11 Thread Daniel Fuchs
Hi Martin, Thanks for pointing that out. I have logged https://bugs.openjdk.java.net/browse/JDK-8215207 best regards, -- daniel On 10/12/2018 19:41, Martin Buchholz wrote: Thanks.  Looks good. Tangentially ... I see URLClassLoader uses URLClassPath which uses FileURLMapper, which tries to d

Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths

2018-12-10 Thread Martin Buchholz
Thanks. Looks good. Tangentially ... I see URLClassLoader uses URLClassPath which uses FileURLMapper, which tries to directly convert a URL to a String path. FileURLMapper uses URL#getFile, and TIL that #getFile differs from #getPath in that it also returns a query component where present. Maybe

Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths

2018-12-10 Thread Alan Bateman
On 10/12/2018 17:54, Daniel Fuchs wrote: Hi Alan, Here is an updated webrev that takes into account your later feedback: http://cr.openjdk.java.net/~dfuchs/webrev_8215008/webrev.02/ This update looks good to me. -Alan

Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths

2018-12-10 Thread Daniel Fuchs
Hi Alan, Here is an updated webrev that takes into account your later feedback: http://cr.openjdk.java.net/~dfuchs/webrev_8215008/webrev.02/ best regards, -- daniel On 07/12/2018 16:16, Daniel Fuchs wrote: Thanks for the feedback Alan! I have updated the webrev accordingly: http://cr.openj

Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths

2018-12-07 Thread Daniel Fuchs
Thanks Chris. Will do. -- daniel On 07/12/2018 16:21, Chris Hegarty wrote: On 7 Dec 2018, at 16:16, Daniel Fuchs wrote: Thanks for the feedback Alan! I have updated the webrev accordingly: http://cr.openjdk.java.net/~dfuchs/webrev_8215008/webrev.01/ Looks good. Maybe userinfo. -Chris

Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths

2018-12-07 Thread Chris Hegarty
> On 7 Dec 2018, at 16:16, Daniel Fuchs wrote: > > Thanks for the feedback Alan! > > I have updated the webrev accordingly: > > http://cr.openjdk.java.net/~dfuchs/webrev_8215008/webrev.01/ Looks good. Maybe userinfo. -Chris.

Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths

2018-12-07 Thread Daniel Fuchs
Thanks for the feedback Alan! I have updated the webrev accordingly: http://cr.openjdk.java.net/~dfuchs/webrev_8215008/webrev.01/ best regards, -- daniel On 07/12/2018 15:20, Alan Bateman wrote: I've come across dozens of cases where code has been trying to use a URL path as a file path so a

Re: RFR 8215008: Clear confusion between URL/URI paths and file system paths

2018-12-07 Thread Alan Bateman
On 07/12/2018 15:13, Daniel Fuchs wrote: Hi, Please find below a fix for 8215008: Clear confusion between URL/URI paths and file system paths https://bugs.openjdk.java.net/browse/JDK-8215008 It adds a small non normative @apiNote to java.net.URL and java.net.URI. http://cr.openjdk.java.net/~df

RFR 8215008: Clear confusion between URL/URI paths and file system paths

2018-12-07 Thread Daniel Fuchs
Hi, Please find below a fix for 8215008: Clear confusion between URL/URI paths and file system paths https://bugs.openjdk.java.net/browse/JDK-8215008 It adds a small non normative @apiNote to java.net.URL and java.net.URI. http://cr.openjdk.java.net/~dfuchs/webrev_8215008/webrev.00/ best regar