On Tuesday 24 April 2018 10:12 PM, Ivan Gerasimov wrote:
Hi Vyom!
On 4/23/18 11:29 PM, vyom tewari wrote:
Hi Ivan,
code looks good to me, thanks for doing this cleanup. One minor
comment, in PortConfig.java you can make defaultUpper& defaultLower
as final.
Yes, of course, they should
Hi Vyom!
On 4/23/18 11:29 PM, vyom tewari wrote:
Hi Ivan,
code looks good to me, thanks for doing this cleanup. One minor
comment, in PortConfig.java you can make defaultUpper& defaultLower as
final.
Yes, of course, they should be final! I'll add it before pushing.
I see that Microsoft
code in java.base/windows/native/libnet
Hi Ivan,
code looks good to me, thanks for doing this cleanup. One minor comment, in
PortConfig.java you can make defaultUpper& defaultLower as final.I see that
Microsoft changed dynamic port range recently do we need to put some comment in
PortConfig.
Hi Ivan,
code looks good to me, thanks for doing this cleanup. One minor comment,
in PortConfig.java you can make defaultUpper& defaultLower as final.I
see that Microsoft changed dynamic port range recently do we need to put
some comment in PortConfig.java ?
Thanks, Vyom
On Tuesday 24 Apri
Hello again!
A few other files contain obsolete code, so they can be combined
together in one fix.
The webrev was updated in place:
http://cr.openjdk.java.net/~igerasim/8202154/00/webrev/
Here's the summary of additional changes:
- sun.net.PortConfig.getLower()/getUpper() always return the sa
