Looks good Chris.
- Michael.
On 24/11/2017, 17:05, Chris Hegarty wrote:
Just an update on this.
There have been many review comments, off line, that have resulted in
changes pushed to the sandbox, so I've refreshed the webrev at the
same location.
http://cr.openjdk.java.net/~chegar/http_clien
Hi Chris,
Thanks for taking on the changes.
The webrev looks good.
best regards,
-- daniel
On 30/11/2017 13:00, Chris Hegarty wrote:
Thanks for the review Daniel.
On 28 Nov 2017, at 18:22, Daniel Fuchs wrote:
Hi Chris,
Thanks for refreshing the webrev with our internal feedback.
You’re
Thanks for the review Daniel.
> On 28 Nov 2017, at 18:22, Daniel Fuchs wrote:
>
> Hi Chris,
>
> Thanks for refreshing the webrev with our internal feedback.
You’re welcome.
> I believe there are still some cleanup we could do to
> wean out some more dead code (for instance I believe
> Excepti
Hi Chris,
Thanks for refreshing the webrev with our internal feedback.
I believe there are still some cleanup we could do to
wean out some more dead code (for instance I believe
ExceptionallyCloseable though implemented - is not
really used anywhere).
There are also some files that contain some
Just an update on this.
There have been many review comments, off line, that have resulted in
changes pushed to the sandbox, so I've refreshed the webrev at the
same location.
http://cr.openjdk.java.net/~chegar/http_client_sandbox_8191494/
-Chris.
On 17/11/17 18:31, Chris Hegarty wrote:
Work o
Work on the incubating HTTP Client has been ongoing in the
`http-client-branch` of the JDK sandbox [1] ( and previously in the JDK
10 sandbox [2] ). This issue proposes to take a snapshot of that work so
as to refresh the version in the JDK mainline. As of now the mainline
that corresponds to J
