Re: RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

Looks good to me. Thanks. > On 21 Jun 2016, at 08:10, Vyom Tewari wrote: > > Hi Pavel, > > Please find the updated > webrev(http://cr.openjdk.java.net/~vtewari/8114860/webrev0.2/index.html > ). I > reverted the commented "ha

Re: RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

Hi Pavel, Please find the updated webrev(http://cr.openjdk.java.net/~vtewari/8114860/webrev0.2/index.html ). I reverted the commented "hashtest" test. Thanks, Vyom On Monday 20 June 2016 10:53 PM, Pavel Rappo wrote: Same

Re: RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

Same here. I got this only after I had a look at the history of changes. > On 20 Jun 2016, at 17:53, Vyom Tewari wrote: > > I was not expecting that hashcodetest is testing NPE by comparing the > "hardcoded" hash values.

Re: RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

Hi Pavel, thanks for review, even i did not understand why test case is comparing the hashcode with the hard coded values that's why at first place i did not removed it. As you mentioned value doesn't matter i will modify the hashcode test and will send the modified webrev again. I was not

Re: RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

Vyom, You've noticed the bug in the code I proposed: "b =" instead of "b +=". Good! (Sorry about that.) When I asked about the strings that were commented out, I meant we'd better do something about it. First of all, because it's almost always not a good idea to *push a commented out code* witho

Re: RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

Hi, Please find the updated webrev(http://cr.openjdk.java.net/~vtewari/8114860/webrev0.1/index.html ). I incorporated the review comments and remove the "HashCodeTest" where it compares the hashcode with hard coded hashcode.

Re: RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

Hi Vyom, thanks for looking into this! 0. * Copyright (c) 2013,2016 Oracle and/or its affiliates. All rights reserved. If I understand correctly, we're not required to update years in the header manually. But if you decided to do so, please follow the established pattern (in both files you've ch

Re: RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

ping! On Saturday 11 June 2016 10:34 AM, vyom wrote: Hi All, Please review the below fix. Bug : JDK-8114860 Behavior of java.net.URLPermission.getActions() contradicts spec Webrev : http://cr.openjdk.java.net/~vtewari/8114860/webrev0.0/index.html

RFR 8114860: Behavior of java.net.URLPermission.getActions() contradicts spec

Hi All, Please review the below fix. Bug : JDK-8114860 Behavior of java.net.URLPermission.getActions() contradicts spec Webrev : http://cr.openjdk.java.net/~vtewari/8114860/webrev0.0/index.html Thanks