Re: RFR 8071660 :URLPermission not handling empty method lists correctly

On 21 Jun 2016, at 11:21, Chris Hegarty wrote: > > The code changes look fine, but the bigger question is whether we > want to support actions without any ‘method’ being specified, like > “:X-Bar”? Should the constructor throw IAE, or is that even possible > now, it would require a spec clarifi

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

The code changes look fine, but the bigger question is whether we want to support actions without any ‘method’ being specified, like “:X-Bar”? Should the constructor throw IAE, or is that even possible now, it would require a spec clarification ( would that invalidate existing code already doing

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

Hi Pavel, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.4/index.html ). I had incorporated the review comments. Thanks, Vyom On Monday 20 June 2016 07:27 PM, Pavel Rappo wrote: Vyom, pl

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

Vyom, please consider the following changes: 1. Append 8071660 to the lists of tests here: * @bug 8010464 8027570 8027687 8029354 8071660 ^ 2. Reformat the code the way it's in the rest of the file: from: 266 URLPermission that = (

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

On 17/06/16 15:09, Vyom Tewari wrote: Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.3/index.html ). I fixed the typo along with spaces issue. Looks good! -- daniel Thanks, Vyom On

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

+1 Thanks, Roger On 6/17/2016 10:27 AM, Chris Hegarty wrote: On 17/06/16 15:09, Vyom Tewari wrote: Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.3/index.html ). I fixed the typo along

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

On 17/06/16 15:09, Vyom Tewari wrote: Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.3/index.html ). I fixed the typo along with spaces issue. Thanks Vyom. Looks good. -Chris. Thanks,

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

Hi, Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.3/index.html ). I fixed the typo along with spaces issue. Thanks, Vyom On Friday 17 June 2016 06:34 PM, Roger Riggs wrote: Hi Vyom, UR

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

Hi Vyom, URLPermissionTest.java: line 125: it looks odd to assign the same variable twice with the same value. Perhaps it should have been assigning this.url2 = url2. line 330-332: please add a space after "," in argument lists. Roger On 6/17/2016 8:42 AM, Daniel Fuchs wrote: On 17/

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

On 17/06/16 13:25, Vyom Tewari wrote: Hi Daniel, thanks for review please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.2/index.html ) . I added some more tests where base url is different. Thanks

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

Hi Daniel, thanks for review please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.2/index.html ) . I added some more tests where base url is different. Thanks, Vyom On Friday 17 June 2016 04:57

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

On 17/06/16 09:21, Vyom Tewari wrote: Hi All, Please find the new webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.1/index.html ). I addressed the review comments given by Daniel. Hi Vyom, Looks good to me - but I'

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

Hi All, Please find the new webrev(http://cr.openjdk.java.net/~vtewari/8071660/webrev0.1/index.html ). I addressed the review comments given by Daniel. Thanks, Vyom On Sunday 12 June 2016 02:04 PM, Daniel Fuchs wrote: Hi

Re: RFR 8071660 :URLPermission not handling empty method lists correctly

Hi Vyom, This looks strange to me: 268 if(!this.methods.isEmpty() && that.methods.isEmpty()) 269 return true; 270 if(this.methods.isEmpty() && !that.methods.isEmpty()) 271 return false; 272 if(this.methods.isEmpty() && that.methods.isEmpty())

RFR 8071660 :URLPermission not handling empty method lists correctly

Hi All, Please review the below fix. Bug : JDK-8071660 URLPermission not handling empty method lists correctly Webrev : http://cr.openjdk.java.net/~vtewari/8071660/webrev0.0/index.html Thanks, Vyom