Re: RFR 8055901: Update policytool for jdk.net.NetworkPermission

2014-08-26 Thread Michael McMahon
On 26/08/14 09:05, Wang Weijun wrote: On Aug 26, 2014, at 15:57, Michael McMahon wrote: Thanks for doing this Max. The syntax looks fine. Just one question. Do you think it is better to specify each socket option literally in the tool as you have done (ie. the only supported NetworkPermission

Re: RFR 8055901: Update policytool for jdk.net.NetworkPermission

2014-08-26 Thread Wang Weijun
On Aug 26, 2014, at 15:57, Michael McMahon wrote: > Thanks for doing this Max. The syntax looks fine. > Just one question. Do you think it is better to specify each socket option > literally in the tool > as you have done (ie. the only supported NetworkPermission > is SO_FLOW_SLA with this chan

Re: RFR 8055901: Update policytool for jdk.net.NetworkPermission

2014-08-26 Thread Michael McMahon
Thanks for doing this Max. The syntax looks fine. Just one question. Do you think it is better to specify each socket option literally in the tool as you have done (ie. the only supported NetworkPermission is SO_FLOW_SLA with this change) or allow users to type in the option name as free-form t

RFR 8055901: Update policytool for jdk.net.NetworkPermission

2014-08-25 Thread Wang Weijun
Hi Michael Please review the code change at http://cr.openjdk.java.net/~weijun/8055901/webrev.00/ With this change, the policy tool can generate a file like grant { permission jdk.net.NetworkPermission "setOption.SO_FLOW_SLA"; }; Please confirm the grammar is correct. BTW, I also add som