Re: RFR 8049220: URL.factory data race

2014-07-07 Thread Paul Sandoz
On Jul 7, 2014, at 1:07 PM, Peter Levart wrote: > Hi Pavel, Alan and Paul, > > Thanks for reviewing. I accepted the suggestions from Pavel and Paul and > created webrev.02: > > http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.02/ > > Is this good to go into jdk9-dev? > Looks

Re: RFR 8049220: URL.factory data race

2014-07-07 Thread Alan Bateman
On 07/07/2014 12:07, Peter Levart wrote: Hi Pavel, Alan and Paul, Thanks for reviewing. I accepted the suggestions from Pavel and Paul and created webrev.02: http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.02/ Is this good to go into jdk9-dev? The comments looks okay to me (a

Re: RFR 8049220: URL.factory data race

2014-07-07 Thread Peter Levart
Hi Pavel, Alan and Paul, Thanks for reviewing. I accepted the suggestions from Pavel and Paul and created webrev.02: http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.02/ Is this good to go into jdk9-dev? Regards, Peter On 07/04/2014 04:54 PM, Paul Sandoz wrote: On Jul 3, 20

Re: RFR 8049220: URL.factory data race

2014-07-04 Thread Paul Sandoz
On Jul 3, 2014, at 6:33 PM, Alan Bateman wrote: > On 03/07/2014 09:43, Peter Levart wrote: >> Hi, >> >> I noticed a data race in java.net.URL: >> >>https://bugs.openjdk.java.net/browse/JDK-8049220 >> >> I propose the following simple patch: >> >> http://cr.openjdk.java.net/~plevart/jdk9-de

Re: RFR 8049220: URL.factory data race

2014-07-03 Thread Alan Bateman
On 03/07/2014 09:43, Peter Levart wrote: Hi, I noticed a data race in java.net.URL: https://bugs.openjdk.java.net/browse/JDK-8049220 I propose the following simple patch: http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.01/ A good catch and the change looks good to me. I

RFR 8049220: URL.factory data race

2014-07-03 Thread Peter Levart
Hi, I noticed a data race in java.net.URL: https://bugs.openjdk.java.net/browse/JDK-8049220 I propose the following simple patch: http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.01/ Regards, Peter