Re: RFR 8026880: NetworkInterface native initializing code should check fieldID values

2013-10-29 Thread Alan Bateman
On 29/10/2013 17:11, Chris Hegarty wrote: D'oh, I spent too much time looking for other places where this was missing, and I forgot about src/windows! Updated webrev: http://cr.openjdk.java.net/~chegar/8026880/webrev.01/ This looks okay to me. -Alan

Re: RFR 8026880: NetworkInterface native initializing code should check fieldID values

2013-10-29 Thread Chris Hegarty
On 10/29/2013 05:00 PM, Alan Bateman wrote: On 29/10/2013 16:56, Chris Hegarty wrote: This is a trivial change, good practice, to check return values from GetFieldID, and friends. I've taken a quick look over the networking native code and see no other similar issues. http://cr.openjdk.java.ne

Re: RFR 8026880: NetworkInterface native initializing code should check fieldID values

2013-10-29 Thread Alan Bateman
On 29/10/2013 16:56, Chris Hegarty wrote: This is a trivial change, good practice, to check return values from GetFieldID, and friends. I've taken a quick look over the networking native code and see no other similar issues. http://cr.openjdk.java.net/~chegar/8026880/webrev.00/ This looks ok

RFR 8026880: NetworkInterface native initializing code should check fieldID values

2013-10-29 Thread Chris Hegarty
This is a trivial change, good practice, to check return values from GetFieldID, and friends. I've taken a quick look over the networking native code and see no other similar issues. http://cr.openjdk.java.net/~chegar/8026880/webrev.00/ -Chris.