Re: RFR 8008223: java/net/BindException/Test.java fails rarely

2013-02-15 Thread Alan Bateman
On 15/02/2013 09:51, Chris Hegarty wrote: On 15/02/2013 08:18, Alan Bateman wrote: I guess this is assuming that their the tests are run with -ea or that the presence of the assert will keep the reference alive. Would it be The presence of the asserts will keep the reference alive even i

Re: RFR 8008223: java/net/BindException/Test.java fails rarely

2013-02-15 Thread Chris Hegarty
On 15/02/2013 08:18, Alan Bateman wrote: I guess this is assuming that their the tests are run with -ea or that the presence of the assert will keep the reference alive. Would it be The presence of the asserts will keep the reference alive even if running without asserts enabled. But it

Re: RFR 8008223: java/net/BindException/Test.java fails rarely

2013-02-15 Thread Alan Bateman
On 14/02/2013 14:43, Chris Hegarty wrote: Webrev: http://cr.openjdk.java.net/~chegar/8008223/webrev.00/webrev/ This test has been around a long time, and rarely fails, but has had several bugs closed as 'not reproducible' marked against it. The test tries to verify that a BindException is t

Re: RFR 8008223: java/net/BindException/Test.java fails rarely

2013-02-14 Thread Kurchi Hazra
I tried out your fix and your solution looks good to me. Thanks, Kurchi On 2/14/2013 6:43 AM, Chris Hegarty wrote: Webrev: http://cr.openjdk.java.net/~chegar/8008223/webrev.00/webrev/ This test has been around a long time, and rarely fails, but has had several bugs closed as 'not reproducib

RFR 8008223: java/net/BindException/Test.java fails rarely

2013-02-14 Thread Chris Hegarty
Webrev: http://cr.openjdk.java.net/~chegar/8008223/webrev.00/webrev/ This test has been around a long time, and rarely fails, but has had several bugs closed as 'not reproducible' marked against it. The test tries to verify that a BindException is thrown, or not thrown, in the appropriate c