Re: RFR 8004925: java/net/Socks/SocksV4Test.java failing on all platforms

2012-12-12 Thread Chris Hegarty
On 12 Dec 2012, at 19:01, Dmitry Samersoff wrote: > On 2012-12-12 22:29, Chris Hegarty wrote: >> On 12/12/2012 18:15, Dmitry Samersoff wrote: >>> Chris, >>> >>> According to rfc2606 TLD .invalid is reserved for cases like this one, >> >> Yes, I came across this, but there is nothing to stop an

Re: RFR 8004925: java/net/Socks/SocksV4Test.java failing on all platforms

2012-12-12 Thread Dmitry Samersoff
On 2012-12-12 22:29, Chris Hegarty wrote: > On 12/12/2012 18:15, Dmitry Samersoff wrote: >> Chris, >> >> According to rfc2606 TLD .invalid is reserved for cases like this one, > > Yes, I came across this, but there is nothing to stop an internal DNS > server from resolving .invalid domains. Anyway

Re: RFR 8004925: java/net/Socks/SocksV4Test.java failing on all platforms

2012-12-12 Thread Chris Hegarty
On 12/12/2012 18:15, Dmitry Samersoff wrote: Chris, According to rfc2606 TLD .invalid is reserved for cases like this one, Yes, I came across this, but there is nothing to stop an internal DNS server from resolving .invalid domains. Anyway, may "doesnot.exist.invalid" would be sufficient.

Re: RFR 8004925: java/net/Socks/SocksV4Test.java failing on all platforms

2012-12-12 Thread Dmitry Samersoff
Chris, According to rfc2606 TLD .invalid is reserved for cases like this one, So, it seems to me domainame.invalid is the best approach. -Dmitry On 2012-12-12 20:15, Chris Hegarty wrote: > > On 12/12/2012 14:14, Alan Bateman wrote: >> >>> -Chris. >> Would it be better if the test S

Re: RFR 8004925: java/net/Socks/SocksV4Test.java failing on all platforms

2012-12-12 Thread Alan Bateman
On 12/12/2012 16:15, Chris Hegarty wrote: On 12/12/2012 14:14, Alan Bateman wrote: -Chris. Would it be better if the test SocksServer had a list of knows that it always rejects? That might speed up the test too as it would avoid is trying to resolve host names or connect to hosts that do

Re: RFR 8004925: java/net/Socks/SocksV4Test.java failing on all platforms

2012-12-12 Thread Chris Hegarty
On 12/12/2012 14:14, Alan Bateman wrote: -Chris. Would it be better if the test SocksServer had a list of knows that it always rejects? That might speed up the test too as it would avoid is trying to resolve host names or connect to hosts that don't exist. The UHE is thrown from the cli

Re: RFR 8004925: java/net/Socks/SocksV4Test.java failing on all platforms

2012-12-12 Thread Alan Bateman
On 12/12/2012 14:02, Chris Hegarty wrote: The test tries to connect (through a socks proxy on the localhost) to a domain that does not exist, "doesnt.exist.name". Guess what, someone just registered a domain with that name! The test should be updated to use a domain name that really doesn't

RFR 8004925: java/net/Socks/SocksV4Test.java failing on all platforms

2012-12-12 Thread Chris Hegarty
The test tries to connect (through a socks proxy on the localhost) to a domain that does not exist, "doesnt.exist.name". Guess what, someone just registered a domain with that name! The test should be updated to use a domain name that really doesn't exist. >: hg diff SocksV4Test.java diff -r