Re: RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c ... AND a potential realloc()-related memory leak.

2012-10-24 Thread Dmitry Samersoff
Kurchi. On 2012-10-24 21:31, Kurchi Hazra wrote: > Just for the sake of understanding the fix better, loRoutesTemp will > point to 0 if the realloc() request fails, > and we still need a reference to the older allocated memory (loRoutes in > this case) in order to free it. Hence > the need for a t

Re: RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c ... AND a potential realloc()-related memory leak.

2012-10-24 Thread Kurchi Hazra
descriptor leak, src/solaris/native/java/net/net_util_md.c ... AND a potential realloc()-related memory leak. Just for the sake of understanding the fix better, loRoutesTemp will point to 0 if the realloc() request fails, and we still need a reference to the older allocated memory (loRoutes in thi

Re: RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c ... AND a potential realloc()-related memory leak.

2012-10-24 Thread John Zavgren
al Message - From: kurchi.subhra.ha...@oracle.com To: john.zavg...@oracle.com Cc: net-dev@openjdk.java.net Sent: Wednesday, October 24, 2012 1:31:36 PM GMT -05:00 US/Canada Eastern Subject: Re: RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c ... AND a potenti

Re: RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c ... AND a potential realloc()-related memory leak.

2012-10-24 Thread Kurchi Hazra
Just for the sake of understanding the fix better, loRoutesTemp will point to 0 if the realloc() request fails, and we still need a reference to the older allocated memory (loRoutes in this case) in order to free it. Hence the need for a temporary variable here? - Kurchi On 24.10.2012 06:27,

Re: RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c ... AND a potential realloc()-related memory leak.

2012-10-24 Thread Dmitry Samersoff
John, Looks good for me! -Dmitry On 2012-10-24 17:16, John Zavgren wrote: > > Greetings: > > I'm requesting a review of a software change that fixes a file descriptor > leak AND a potential memory leak that involves memory reallocation > (realloc()). The webrev image is in the following loca

Re: RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c ... AND a potential realloc()-related memory leak.

2012-10-24 Thread Chris Hegarty
Looks good to me. Thanks for going the extra mile here. -Chris. On 24/10/2012 14:16, John Zavgren wrote: Greetings: I'm requesting a review of a software change that fixes a file descriptor leak AND a potential memory leak that involves memory reallocation (realloc()). The webrev image is i

RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c ... AND a potential realloc()-related memory leak.

2012-10-24 Thread John Zavgren
Greetings: I'm requesting a review of a software change that fixes a file descriptor leak AND a potential memory leak that involves memory reallocation (realloc()). The webrev image is in the following location: http://cr.openjdk.java.net/~chegar/8000203/webrev.01/ Thanks! John Zavgren john.z

Re: RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c

2012-10-23 Thread Jim Gish
Looks good to me. Jim - Original Message - From: john.zavg...@oracle.com To: net-dev@openjdk.java.net Sent: Tuesday, October 23, 2012 10:57:06 AM GMT -05:00 US/Canada Eastern Subject: RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c Greetings: I&#

Re: RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c

2012-10-23 Thread Chris Hegarty
Looks fine to me John. -Chris. On 10/23/2012 03:56 PM, John Zavgren wrote: Greetings: I'm requesting a review of a proposed change that fixes a file descriptor leak. The webrev image is in the following location: http://cr.openjdk.java.net/~chegar/8000203/webrev.00/ Thanks! John Zavgren joh

RFR 8000203: file descriptor leak, src/solaris/native/java/net/net_util_md.c

2012-10-23 Thread John Zavgren
Greetings: I'm requesting a review of a proposed change that fixes a file descriptor leak. The webrev image is in the following location: http://cr.openjdk.java.net/~chegar/8000203/webrev.00/ Thanks! John Zavgren john.zavg...@oracle.com