Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

On 29 Mar 2016, at 17:38, vyom wrote: > On Tuesday 29 March 2016 09:10 PM, Chris Hegarty wrote: >> On 29 Mar 2016, at 16:20, Roger Riggs wrote: >> >>> Looks good, >> +1 >> >> Does the test need to be run in othervm mode ? > I don't think othervm mode required, do you wants to me to generate an

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

On Tuesday 29 March 2016 09:10 PM, Chris Hegarty wrote: On 29 Mar 2016, at 16:20, Roger Riggs wrote: Looks good, +1 Does the test need to be run in othervm mode ? I don't think othervm mode required, do you wants to me to generate another webrev(0.5) ? -Chris. Thanks, Roger On 3/29/

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

On 29 Mar 2016, at 16:20, Roger Riggs wrote: > Looks good, +1 Does the test need to be run in othervm mode ? -Chris. > Thanks, Roger > > > On 3/29/2016 11:00 AM, vyom wrote: >> Hi, >> >> Please find the updated webrev. >> http://cr.openjdk.java.net/~vtewari/7167293/webrev0.4/index.html

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

Looks good, Thanks, Roger On 3/29/2016 11:00 AM, vyom wrote: Hi, Please find the updated webrev. http://cr.openjdk.java.net/~vtewari/7167293/webrev0.4/index.html Thanks, Vyom On Tuesday 29 March 2016 07:49 PM, Roger Rigg

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

Hi, Please find the updated webrev. http://cr.openjdk.java.net/~vtewari/7167293/webrev0.4/index.html Thanks, Vyom On Tuesday 29 March 2016 07:49 PM, Roger Riggs wrote: Hi Vyom, A minor cleanup to reduce the size of the lit

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

Hi Vyom, A minor cleanup to reduce the size of the little used code. Create the FNFE before checking and closing. Then the form of the cleanup code will be consistent and there will be less code. For example, +FileNotFoundException fnfe = new FileNotFoundException(fullpath);

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

please find that updated webrev(http://cr.openjdk.java.net/~vtewari/7167293/webrev0.3 ), I incorporated Roger's comments. Thanks, Vyom On Wednesday 23 March 2016 10:04 PM, Roger Riggs wrote: Hi Vyom, I think it should be the case that

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

Hi Vyom, I think it should be the case that the same exception (FrpProtocol, IOException) should be rethrown instead of the exception that resulted from the call to close. In many case, the exceptions from a call to a cleanup close() are simply ignored but the alternative is to add them as su

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

Hi, Please find the updated webrev, got some off line comment from Chris. http://cr.openjdk.java.net/~vtewari/7167293/webrev0.2/index.html Thanks, Vyom On Thursday 17 March 2016 12:30 PM, vyom wrote: please find the updated

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

please find the updated webrev(http://cr.openjdk.java.net/~vtewari/7167293/webrev0.1/index.html ). Thanks, Vyom On Tuesday 15 March 2016 05:11 PM, Chris Hegarty wrote: Vyom, On 15/03/16 10:00, vyom wrote: Hi, Please review

Re: RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

Vyom, On 15/03/16 10:00, vyom wrote: Hi, Please review the below fix. Bug: JDK-7167293 : FtpURLConnection connection leak on FileNotFoundException Webrev: http://cr.openjdk.java.net/~rgoel/~vyom/7167293/webrev0.0/ You have the

RFR 7167293:FtpURLConnection connection leak on FileNotFoundException

Hi, Please review the below fix. Bug: JDK-7167293 : FtpURLConnection connection leak on FileNotFoundException Webrev: http://cr.openjdk.java.net/~rgoel/~vyom/7167293/webrev0.0/ Thanks, Vyom