Re: RFR [9] 8178161: Default multicast interface on Mac

2017-04-06 Thread Brian Burkhalter
On Apr 6, 2017, at 11:07 AM, Chris Hegarty wrote: >> On 6 Apr 2017, at 17:50, Michael McMahon >> wrote: >> >> Looks fine to me Chris. Stylistically, the boolean tests >> in line 104 could remove the == true obviously, but not a big deal. > > Thanks, I’ll make this change before pushing. +1

Re: RFR [9] 8178161: Default multicast interface on Mac

2017-04-06 Thread Chris Hegarty
> On 6 Apr 2017, at 17:50, Michael McMahon wrote: > > Looks fine to me Chris. Stylistically, the boolean tests > in line 104 could remove the == true obviously, but not a big deal. Thanks, I’ll make this change before pushing. -Chris.

Re: RFR [9] 8178161: Default multicast interface on Mac

2017-04-06 Thread Michael McMahon
Looks fine to me Chris. Stylistically, the boolean tests in line 104 could remove the == true obviously, but not a big deal. Michael. On 06/04/2017, 17:15, Chris Hegarty wrote: Because of some peculiarities on Mac the original Mac port brought some code that attempts to determine the default ne

RFR [9] 8178161: Default multicast interface on Mac

2017-04-06 Thread Chris Hegarty
Because of some peculiarities on Mac the original Mac port brought some code that attempts to determine the default network interface ( on Mac only ). In all cases, on recent OS and hardware, it now finds the Apple peer-to-peer interface, awdl0, which is almost always the wrong answer. This is frag