> On 25 Jan 2019, at 17:04, Chris Hegarty wrote:
>
> I moved the code to common.Utils, to avoid any unnecessary dependency.
Thanks.
>> 2. Why does this change add server.close() to each and every test method of
>> WebSocketTest? If I'm not mistaken that's what @AfterTest public void
>> clea
Thanks Chris.
Makes sense, and looks good!
best regards,
-- daniel
On 25/01/2019 17:07, Chris Hegarty wrote:
Daniel,
On 25 Jan 2019, at 15:34, Daniel Fuchs wrote:
Hi Chris,
Looks good.
I had the same question than Pavel about server.close().
Answered already in reply to Pavel’s questio
Daniel,
> On 25 Jan 2019, at 15:34, Daniel Fuchs wrote:
>
> Hi Chris,
>
> Looks good.
> I had the same question than Pavel about server.close().
Answered already in reply to Pavel’s question.
> No test for both proxy + server authorization with
> -Djdk.http.auth.tunneling.disabledSchemes ?
N
Pavel,
> On 25 Jan 2019, at 15:16, Pavel Rappo wrote:
>
> Chris, thanks for doing this! I have two questions on this change.
>
> 1. After this change has been applied, there will be a circular dependency
> between HttpRequestImpl and OpeningHandshake. If this code is used by these
> two
> clas
Hi Chris,
Looks good.
I had the same question than Pavel about server.close().
No test for both proxy + server authorization with
-Djdk.http.auth.tunneling.disabledSchemes ?
cheers,
-- daniel
On 25/01/2019 14:21, Chris Hegarty wrote:
When tunneling WebSocket over a proxy requiring authentica
Chris, thanks for doing this! I have two questions on this change.
1. After this change has been applied, there will be a circular dependency
between HttpRequestImpl and OpeningHandshake. If this code is used by these two
classes maybe we are better off extracting it into some (already existing) t
When tunneling WebSocket over a proxy requiring authentication, the
implementation must ensure that the appropriate Upgrade headers are
not lost after the tunnel has been established. The source changes are
quite straight forward, the remaining bulk of the changes are to address
a deficiency in the
