Re: RFR [12] 8210493: Bind to node- or linklocal ipv6 multicast address fails

2018-11-12 Thread Chris Hegarty
On 09/11/18 14:33, Pavel Rappo wrote: Alan, Chris, Thanks for reviewing this change. However, before the push I tested it again and found out that there is a small number of Linux machines on which both tests fail. The only thing I found to be in common between these machines was the version of

Re: RFR [12] 8210493: Bind to node- or linklocal ipv6 multicast address fails

2018-11-09 Thread Pavel Rappo
Alan, Chris, Thanks for reviewing this change. However, before the push I tested it again and found out that there is a small number of Linux machines on which both tests fail. The only thing I found to be in common between these machines was the version of the Linux kernel. Machines with the 3.10

Re: RFR [12] 8210493: Bind to node- or linklocal ipv6 multicast address fails

2018-11-07 Thread Alan Bateman
On 07/11/2018 16:23, Pavel Rappo wrote: On 7 Nov 2018, at 15:22, Alan Bateman wrote: Does the comment at L806 need to be updated? Also the change makes me wondering about the 2.4 kernel support, maybe it is time to think about dropping some of the older code path. Alan, Is that better?

Re: RFR [12] 8210493: Bind to node- or linklocal ipv6 multicast address fails

2018-11-07 Thread Pavel Rappo
> On 7 Nov 2018, at 15:22, Alan Bateman wrote: > > Does the comment at L806 need to be updated? Also the change makes me > wondering about the 2.4 kernel support, maybe it is time to think about > dropping some of the older code path. Alan, Is that better? http://cr.openjdk.java.net/~prap

Re: RFR [12] 8210493: Bind to node- or linklocal ipv6 multicast address fails

2018-11-07 Thread Chris Hegarty
On 07/11/18 14:12, Pavel Rappo wrote: Hello, Please review the following change: http://cr.openjdk.java.net/~prappo/8210493/webrev.00 Thanks for doing this Pavel. The changes in the webrev look good to me. -Chris.

Re: RFR [12] 8210493: Bind to node- or linklocal ipv6 multicast address fails

2018-11-07 Thread Alan Bateman
On 07/11/2018 14:12, Pavel Rappo wrote: Hello, Please review the following change: http://cr.openjdk.java.net/~prappo/8210493/webrev.00 This change fixes binding to interface-local and link-local IPv6 multicast addresses on Linux. Does the comment at L806 need to be updated? Also the change

RFR [12] 8210493: Bind to node- or linklocal ipv6 multicast address fails

2018-11-07 Thread Pavel Rappo
Hello, Please review the following change: http://cr.openjdk.java.net/~prappo/8210493/webrev.00 This change fixes binding to interface-local and link-local IPv6 multicast addresses on Linux. Thanks, -Pavel