Re: RFR[8234103]: DatagramSocketImpl::socket is not needed

2019-11-20 Thread Chris Hegarty
> On 14/11/2019 12:24, Patrick Concannon wrote: >> .. >> webrev: http://cr.openjdk.java.net/~pconcannon/8234103/webrevs/webrev.01/ LGTM. -Chris.

Re: RFR[8234103]: DatagramSocketImpl::socket is not needed

2019-11-20 Thread Daniel Fuchs
On 14/11/2019 12:24, Patrick Concannon wrote: Hi Daniel, I've added the comment, and you can find it in the new webrev below. webrev: http://cr.openjdk.java.net/~pconcannon/8234103/webrevs/webrev.01/ Looks good Patrick - I think we could push that if you can generate a properly formatted cha

Re: RFR[8234103]: DatagramSocketImpl::socket is not needed

2019-11-14 Thread Alan Bateman
On 14/11/2019 11:58, Patrick Concannon wrote: Hi, Could someone please review my fix for issue JDK-8234103 'DatagramSocketImpl::socket is not needed' ? DatagramSocketImpl has a socket field that links back to the DatagramSocket, which is only used to determine whether this DatagramSocket su

Re: RFR[8234103]: DatagramSocketImpl::socket is not needed

2019-11-14 Thread Patrick Concannon
Hi Daniel, I've added the comment, and you can find it in the new webrev below. webrev: http://cr.openjdk.java.net/~pconcannon/8234103/webrevs/webrev.01/ Kind regards, Patrick On 14/11/2019 12:12, Daniel Fuchs wrote: Hi Patrick, Thanks for helping getting rid of this old technical debt!

Re: RFR[8234103]: DatagramSocketImpl::socket is not needed

2019-11-14 Thread Daniel Fuchs
Hi Patrick, Thanks for helping getting rid of this old technical debt! In DualStackPlainDatagramSocketImpl.java: 64 DualStackPlainDatagramSocketImpl(boolean exclBind) { 65 super(false); Maybe add a comment to clarify the meaning of `false`: 65 super(false); // DualSt

RFR[8234103]: DatagramSocketImpl::socket is not needed

2019-11-14 Thread Patrick Concannon
Hi, Could someone please review my fix for issue JDK-8234103 'DatagramSocketImpl::socket is not needed' ? DatagramSocketImpl has a socket field that links back to the DatagramSocket, which is only used to determine whether this DatagramSocket support Multicast or not. This fix removes the D