Re: RFR[8231570]: (dc) Clarify implicit bind behavior of DatagramChannel

2019-10-24 Thread Chris Hegarty
> On 16 Oct 2019, at 19:20, Patrick Concannon > wrote: > > [Resending with nio-dev in cc] > > Hi, > > > Could someone please review my fix and CSR for issue JDK-8231570 '(dc) > Clarify implicit bind behavior of DatagramChannel' ? > > The fix clarifies the security checks for DatagramChann

Re: RFR[8231570]: (dc) Clarify implicit bind behavior of DatagramChannel

2019-10-23 Thread Daniel Fuchs
Hi Patrick, That looks good to me too. I can sponsor it for you after you generate a proper hg-importable changeset. best regards, -- daniel On 16/10/2019 19:20, Patrick Concannon wrote: [Resending with nio-dev in cc] Hi, Could someone please review my fix and CSR for issue JDK-8231570 '(d

Re: RFR[8231570]: (dc) Clarify implicit bind behavior of DatagramChannel

2019-10-16 Thread Alan Bateman
On 16/10/2019 19:20, Patrick Concannon wrote: : webrev: http://cr.openjdk.java.net/~pconcannon/8231570/webrevs/webrev.02/ Looks good.

RFR[8231570]: (dc) Clarify implicit bind behavior of DatagramChannel

2019-10-16 Thread Patrick Concannon
[Resending with nio-dev in cc] Hi, Could someone please review my fix and CSR for issue JDK-8231570 '(dc) Clarify implicit bind behavior of DatagramChannel' ? The fix clarifies the security checks for DatagramChannel connect, send, and receive methods. webrev: http://cr.openjdk.java.net/

RFR[8231570]: (dc) Clarify implicit bind behavior of DatagramChannel

2019-10-16 Thread Patrick Concannon
Hi, Could someone please review my fix and CSR for issue JDK-8231570 '(dc) Clarify implicit bind behavior of DatagramChannel' ? The fix clarifies the security checks for DatagramChannel connect, send, and receive methods. webrev: http://cr.openjdk.java.net/~pconcannon/8231570/webrevs/webr