Re: RFR: JDK-8026245, , InetAddress.getLocalHost crash if IPv6 disabled (macosx)

2013-10-15 Thread Chris Hegarty
Thank you Rob, this looks good to me. -Chris. On 10/15/2013 04:32 PM, Rob McKenna wrote: Updated webrev at: http://cr.openjdk.java.net/~robm/8026245/webrev.02/ -Rob On 15/10/13 15:31, Rob McKenna wrote: Caught me. I've just updated the tests in place actually. Another jprt job is in pr

Re: RFR: JDK-8026245, , InetAddress.getLocalHost crash if IPv6 disabled (macosx)

2013-10-15 Thread Rob McKenna
Updated webrev at: http://cr.openjdk.java.net/~robm/8026245/webrev.02/ -Rob On 15/10/13 15:31, Rob McKenna wrote: Caught me. I've just updated the tests in place actually. Another jprt job is in progress. (I've just checked preferIPv4 manually and it passes) I'll add a new webrev with yo

Re: RFR: JDK-8026245, , InetAddress.getLocalHost crash if IPv6 disabled (macosx)

2013-10-15 Thread Rob McKenna
Caught me. I've just updated the tests in place actually. Another jprt job is in progress. (I've just checked preferIPv4 manually and it passes) I'll add a new webrev with your other suggestions. -Rob On 15/10/13 15:23, Alan Bateman wrote: On 15/10/2013 15:05, Rob McKenna wrote: Hi folks

Re: RFR: JDK-8026245, , InetAddress.getLocalHost crash if IPv6 disabled (macosx)

2013-10-15 Thread Alan Bateman
On 15/10/2013 15:05, Rob McKenna wrote: Hi folks, Looking for a review for the following: http://cr.openjdk.java.net/~robm/8026245/webrev.01/ It seems there were a number of issues with the original fix for 7180557. This patch resolves those: - No existing net tests exercised the ipv4 only

RFR: JDK-8026245,,InetAddress.getLocalHost crash if IPv6 disabled (macosx)

2013-10-15 Thread Rob McKenna
Hi folks, Looking for a review for the following: http://cr.openjdk.java.net/~robm/8026245/webrev.01/ It seems there were a number of issues with the original fix for 7180557. This patch resolves those: - No existing net tests exercised the ipv4 only codepath - the extern to lookupIfLocalhos