Re: RFR: JDK-8025437 - Check DefaultProxySelector for JNI pending exception issues

2013-12-12 Thread Dan Xu
Sorry for the typo. I mean that I am waiting for jdk 9 repo to be open. -Dan On 12/12/2013 07:54 PM, Dan Xu wrote: Thanks for the review. The fix is for 9 not 8. I am waiting for jdk 8 repo to be open. -Dan On 12/12/2013 02:49 AM, Michael McMahon wrote: Yes, looks good Dan. I presume this is

Re: RFR: JDK-8025437 - Check DefaultProxySelector for JNI pending exception issues

2013-12-12 Thread Dan Xu
Thanks for the review. The fix is for 9 not 8. I am waiting for jdk 8 repo to be open. -Dan On 12/12/2013 02:49 AM, Michael McMahon wrote: Yes, looks good Dan. I presume this is going into 9 rather than 8 though...? Michael. On 12/12/13 05:14, Dan Xu wrote: Hi All, Please review the fix f

Re: RFR: JDK-8025437 - Check DefaultProxySelector for JNI pending exception issues

2013-12-12 Thread Michael McMahon
Yes, looks good Dan. I presume this is going into 9 rather than 8 though...? Michael. On 12/12/13 05:14, Dan Xu wrote: Hi All, Please review the fix for the JNI pending exception issue in src/solaris/native/sun/net/spi/DefaultProxySelector.c. I have refactored the code so that JNI calls will

Re: RFR: JDK-8025437 - Check DefaultProxySelector for JNI pending exception issues

2013-12-12 Thread Chris Hegarty
Looks good to me. Thanks Dan. -Chris. On 12 Dec 2013, at 05:14, Dan Xu wrote: > Hi All, > > Please review the fix for the JNI pending exception issue in > src/solaris/native/sun/net/spi/DefaultProxySelector.c. I have refactored the > code so that JNI calls will only be run when previous JNI

RFR: JDK-8025437 - Check DefaultProxySelector for JNI pending exception issues

2013-12-11 Thread Dan Xu
Hi All, Please review the fix for the JNI pending exception issue in src/solaris/native/sun/net/spi/DefaultProxySelector.c. I have refactored the code so that JNI calls will only be run when previous JNI calls succeed. Therefore, it is impossible for an unsafe JNI call to happen. Please help