Re: RFR: JDK-7122887 - JDK ignores Gnome3 proxy settings

2013-10-23 Thread Chris Hegarty
On 10/23/2013 07:53 PM, Dan Xu wrote: Hi, I have moved initJavaClass function into Java_sun_net_spi_DefaultProxySelector_init to only initialize the java objects once. The updated webrev can be reviewed at http://cr.openjdk.java.net/~dxu/7122887/webrev.01/

Re: RFR: JDK-7122887 - JDK ignores Gnome3 proxy settings

2013-10-23 Thread Dan Xu
Hi, I have moved initJavaClass function into Java_sun_net_spi_DefaultProxySelector_init to only initialize the java objects once. The updated webrev can be reviewed at http://cr.openjdk.java.net/~dxu/7122887/webrev.01/ . Thanks! -Dan On

Re: RFR: JDK-7122887 - JDK ignores Gnome3 proxy settings

2013-10-23 Thread Dan Xu
You are right, Chris. The java class objects initialization should be in the init method. I will update it now. Thanks for the review! -Dan On 10/23/2013 11:21 AM, Chris Hegarty wrote: Hi Dan, Firstly, thank you for working on this. This is really useful, and I'm glad to see it going into J

Re: RFR: JDK-7122887 - JDK ignores Gnome3 proxy settings

2013-10-23 Thread Chris Hegarty
Hi Dan, Firstly, thank you for working on this. This is really useful, and I'm glad to see it going into JDK 8. I grabed the patch and built it. All looks fine, and the updates you added to the manual test are really useful to verify the implementation. All in all I'm happy with this change

RFR: JDK-7122887 - JDK ignores Gnome3 proxy settings

2013-10-22 Thread Dan Xu
Hi All, Please review the fix towards gnome proxy settings. In the recent Gnome versions, it has phased out GConf and swithed to use GSettings to handle all the system configurations. But in JDK, we are still use GConf-based proxy resolution, which generates wrong results in the latest linux