On 16/09/13 13:53, Chris Hegarty wrote:
On 16/09/2013 12:11, Michael McMahon wrote:
...
yep. Forget that as well. I thought it was being called from common
code. So, I'm missing how this
code is relevant then on Vista, which should be using the dual stack
implementation then ?
Multicasting on
On 16/09/2013 12:11, Michael McMahon wrote:
...
yep. Forget that as well. I thought it was being called from common
code. So, I'm missing how this
code is relevant then on Vista, which should be using the dual stack
implementation then ?
Multicasting on Windows still uses the two stack impleme
Not sure about Vista per se ... Initially I ran the test case on
windows 7 and the same failures existed
so on analysis and tracing lead me to the TwoStackPlainDatagramSocketImpl
I'm dependent on JPRT to handle the vista case ... if a Vista box exists
I can run the test explicitly on it to ensu
On 16/09/13 11:33, Chris Hegarty wrote:
Mark,
From what I can see, I think the changes are correct.
On 16/09/2013 11:10, Michael McMahon wrote:
One comment so far. The ipv4mode parameter in
getIPv4NetworkInterface()
seems superfluous, with the call using parameter value "0"
could be just eli
Thanks Chris more lucid than my own reply
Mark
On 16/09/2013 11:33, Chris Hegarty wrote:
Mark,
From what I can see, I think the changes are correct.
On 16/09/2013 11:10, Michael McMahon wrote:
One comment so far. The ipv4mode parameter in
getIPv4NetworkInterface()
seems superfluous,
Hi Michael,
thanks for the response.
the getIPv4NetworkInterface is called in two places within the
getMulticastInterface function. It's a refactoring of what would have been
duplicate code. This lead to the "boolean" ipv4Mode.
line 2039
if (isIPV4) {
jobject netObject = NULL; //
Mark,
From what I can see, I think the changes are correct.
On 16/09/2013 11:10, Michael McMahon wrote:
One comment so far. The ipv4mode parameter in
getIPv4NetworkInterface()
seems superfluous, with the call using parameter value "0"
could be just elided to using the null return value direct
One comment so far. The ipv4mode parameter in
getIPv4NetworkInterface()
seems superfluous, with the call using parameter value "0"
could be just elided to using the null return value directly.
I was a bit confused also that the new function is in the TwoStacks...
module,
but it seems this file
Hi
please oblige and review the webrev below which addresses the issue
problem:
https://bugs.openjdk.java.net/browse/JDK-6458027
webrev:
http://cr.openjdk.java.net/~msheppar/6458027/webrev/
the core of the issue is that a windows platform may be IPv6 enabled, but
an individual adapter/interf