Re: RFR: 8282917: Remove InetAddressImplFactory from InetAddress [v3]

2022-03-16 Thread Jaikiran Pai
On Wed, 16 Mar 2022 17:47:15 GMT, Aleksei Efimov wrote: >> Thanks for noticing that Jaikiran! >> >> Both `ipv4_available()` and `ipv6_available()` are defined to return `jint` >> so the implementation in `Java_java_net_InetAddress_isIPv6Supported` is >> arguably the more correct (provided that

Re: RFR: 8282917: Remove InetAddressImplFactory from InetAddress [v3]

2022-03-16 Thread Jaikiran Pai
On Wed, 16 Mar 2022 17:51:17 GMT, Aleksei Efimov wrote: >> Hi, >> >> This cleanup change removes `InetAddressImplFactory` class from >> `InetAddress`. The list of changes: >> - Remove `InetAddressImplFactory` from `InetAddress` >> - Since `isIPv6Supported` native code is identical for Windows a

Re: RFR: 8282917: Remove InetAddressImplFactory from InetAddress [v3]

2022-03-16 Thread Daniel Fuchs
On Wed, 16 Mar 2022 17:51:17 GMT, Aleksei Efimov wrote: >> Hi, >> >> This cleanup change removes `InetAddressImplFactory` class from >> `InetAddress`. The list of changes: >> - Remove `InetAddressImplFactory` from `InetAddress` >> - Since `isIPv6Supported` native code is identical for Windows a

Re: RFR: 8282917: Remove InetAddressImplFactory from InetAddress [v3]

2022-03-16 Thread Aleksei Efimov
On Wed, 16 Mar 2022 14:34:49 GMT, Daniel Fuchs wrote: >> I agree that it could be simplified to match >> `Java_java_net_InetAddress_isIPv4Available`. Changed in >> 49fdd576cade2e97639f827f9db6d0f1e31101e2 > > Thanks for noticing that Jaikiran! > > Both `ipv4_available()` and `ipv6_available()`

Re: RFR: 8282917: Remove InetAddressImplFactory from InetAddress [v3]

2022-03-16 Thread Aleksei Efimov
> Hi, > > This cleanup change removes `InetAddressImplFactory` class from > `InetAddress`. The list of changes: > - Remove `InetAddressImplFactory` from `InetAddress` > - Since `isIPv6Supported` native code is identical for Windows and Unix > implementations it was moved to the libnet's `InetAdd