On Sat, 5 Feb 2022 13:22:25 GMT, Claes Redestad wrote:
> There's a small compatibility risk with this change, e.g.,
> `List.copyOf(...).contains(null)` will throw NPE while
> `Collections.unmodifiableList(...).contains(null)` won't.
>
> If we accept that compatibility risk (which should probab
On Fri, 4 Feb 2022 23:02:21 GMT, Xue-Lei Andrew Fan wrote:
> Please review this trivial code clean up, for a little bit better performance.
There's a small compatibility risk with this change, e.g.,
`List.copyOf(...).contains(null)` will throw NPE while
`Collections.unmodifiableList(...).conta
On Fri, 4 Feb 2022 23:02:21 GMT, Xue-Lei Andrew Fan wrote:
> Please review this trivial code clean up, for a little bit better performance.
Marked as reviewed by hchao (Committer).
Looks good to me.
-
PR: https://git.openjdk.java.net/jdk/pull/7356
On Fri, 4 Feb 2022 23:02:21 GMT, Xue-Lei Andrew Fan wrote:
> Please review this trivial code clean up, for a little bit better performance.
Looks good to me.
-
Marked as reviewed by jnimeh (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7356
Please review this trivial code clean up, for a little bit better performance.
-
Commit messages:
- 8281289: Improve with List.copyOf
Changes: https://git.openjdk.java.net/jdk/pull/7356/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7356&range=00
Issue: https://bugs.